Skip to content

Commit 0fab063

Browse files
wan9chiclaude
andcommitted
chore: move vite-task-client build tooling to monorepo root
When `@voidzero-dev/vite-task-client` is consumed via the `github:` spec, its `package.json` is read by the consumer's pnpm. With `scripts` and `devDependencies: { ...: "catalog:" }` declared at the subpackage level, the unresolved `catalog:` refs from a foreign workspace broke installation downstream (typecheck failed with TS2307 "Cannot find module @voidzero-dev/vite-task-client"). Move the `tsc` script and its `typescript` + `@tsconfig/strictest` devDeps up to the monorepo root, and have the subpackage's `package.json` stay minimal (name/main/types only). The CI step now runs the root `build-vite-task-client-types` script; tsc still uses `packages/vite-task-client/tsconfig.json` so the emission is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent ea80a59 commit 0fab063

4 files changed

Lines changed: 14 additions & 23 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ jobs:
224224

225225
- name: Check vite-task-client types are not stale
226226
run: |
227-
pnpm --filter @voidzero-dev/vite-task-client run build:types
227+
pnpm build-vite-task-client-types
228228
git diff --exit-code packages/vite-task-client/index.d.ts
229229
230230
done:

package.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,18 @@
44
"license": "MIT",
55
"type": "module",
66
"scripts": {
7-
"prepare": "husky || true"
7+
"prepare": "husky || true",
8+
"build-vite-task-client-types": "tsc -p packages/vite-task-client/tsconfig.json"
89
},
910
"devDependencies": {
11+
"@tsconfig/strictest": "catalog:",
1012
"@types/node": "catalog:",
1113
"husky": "catalog:",
1214
"lint-staged": "catalog:",
1315
"oxfmt": "catalog:",
1416
"oxlint": "catalog:",
15-
"oxlint-tsgolint": "catalog:"
17+
"oxlint-tsgolint": "catalog:",
18+
"typescript": "catalog:"
1619
},
1720
"lint-staged": {
1821
"*": "oxfmt --no-error-on-unmatched-pattern",

packages/vite-task-client/package.json

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,5 @@
44
"private": true,
55
"type": "module",
66
"main": "./index.js",
7-
"types": "./index.d.ts",
8-
"scripts": {
9-
"build:types": "tsc"
10-
},
11-
"devDependencies": {
12-
"@tsconfig/strictest": "catalog:",
13-
"@types/node": "catalog:",
14-
"typescript": "catalog:"
15-
}
7+
"types": "./index.d.ts"
168
}

pnpm-lock.yaml

Lines changed: 7 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)