Skip to content

Commit 1d7128e

Browse files
branchseerclaude
andauthored
fix: increase e2e test step timeout on Windows to fix flaky CI (#252)
## Summary - Increases the per-step timeout for e2e snapshot tests from 20s to 60s on Windows, while keeping 20s on Unix - Windows CI runners using Git Bash have significantly more overhead for shell startup and process execution - The 20-second timeout was frequently exceeded, causing flaky `[timeout]` failures in tests like `summary-output` and `filter-unmatched` ## Failure patterns observed | Pattern | Tests affected | Frequency | |---------|---------------|-----------| | `[timeout]` on first step | `summary-output`, `filter-unmatched` | Most common (3+ occurrences) | | `[127] command not found` | `exit-codes` | Occasional | ## Test plan - [x] Compiles locally (`cargo check -p vite_task_bin --test e2e_snapshots`) - [ ] Validate by re-running Windows CI at least 10 times to confirm flakiness is resolved https://claude.ai/code/session_01VzFJkUBQ9t6zTmH7ZJFXgt --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent 665d553 commit 1d7128e

File tree

1 file changed

+4
-2
lines changed
  • crates/vite_task_bin/tests/e2e_snapshots

1 file changed

+4
-2
lines changed

crates/vite_task_bin/tests/e2e_snapshots/main.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@ use vite_path::{AbsolutePath, AbsolutePathBuf, RelativePathBuf};
1717
use vite_str::Str;
1818
use vite_workspace::find_workspace_root;
1919

20-
/// Timeout for each step in e2e tests
21-
const STEP_TIMEOUT: Duration = Duration::from_secs(20);
20+
/// Timeout for each step in e2e tests.
21+
/// Windows CI needs a longer timeout due to Git Bash startup overhead and slower I/O.
22+
const STEP_TIMEOUT: Duration =
23+
if cfg!(windows) { Duration::from_secs(60) } else { Duration::from_secs(20) };
2224

2325
/// Screen size for the PTY terminal. Large enough to avoid line wrapping.
2426
const SCREEN_SIZE: ScreenSize = ScreenSize { rows: 500, cols: 500 };

0 commit comments

Comments
 (0)