Skip to content

Commit 24434e8

Browse files
branchseerclaude
andauthored
fix: update task selector prompt to indicate search capability (#222)
## Summary Updated the interactive task selector prompt text to better communicate the search functionality available to users. ## Changes - Changed the help text in the task selector prompt from "Esc to clear" to "Type to search" - Updated in `crates/vite_select/src/interactive.rs` where the prompt is rendered - Updated the corresponding test assertion to match the new prompt text - Updated all e2e snapshot tests to reflect the new prompt text across 15 test fixtures ## Details The original prompt text "Select a task (↑/↓, Enter to run, Esc to clear)" was misleading as it emphasized the Escape key functionality while not clearly indicating that users can type to search for tasks. The new text "Select a task (↑/↓, Enter to run, Type to search)" better communicates the primary interactive features available to users and makes the search capability more discoverable. https://claude.ai/code/session_01FbckcRhug9ZfpUREosapX4 --------- Co-authored-by: Claude <noreply@anthropic.com>
1 parent d97c9bb commit 24434e8

15 files changed

+33
-33
lines changed

crates/vite_select/src/interactive.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -288,12 +288,12 @@ pub fn render_items(writer: &mut impl Write, params: &RenderParams<'_>) -> anyho
288288
if q.is_empty() {
289289
write!(
290290
writer,
291-
"Select a task (\u{2191}/\u{2193}, Enter to run, Esc to clear):{line_ending}",
291+
"Select a task (\u{2191}/\u{2193}, Enter to run, type to search):{line_ending}",
292292
)?;
293293
} else {
294294
write!(
295295
writer,
296-
"Select a task (\u{2191}/\u{2193}, Enter to run, Esc to clear): {q}{line_ending}",
296+
"Select a task (\u{2191}/\u{2193}, Enter to run, type to search): {q}{line_ending}",
297297
)?;
298298
}
299299
write!(writer, "{line_ending}")?;
@@ -740,7 +740,7 @@ mod tests {
740740
let spacer = lines.next().unwrap();
741741
let selected = lines.next().unwrap();
742742
let unselected = lines.next().unwrap();
743-
assert_eq!(prompt, "Select a task (\u{2191}/\u{2193}, Enter to run, Esc to clear):");
743+
assert_eq!(prompt, "Select a task (\u{2191}/\u{2193}, Enter to run, type to search):");
744744
assert!(spacer.is_empty());
745745
assert_eq!(selected, " \u{203a} build echo build");
746746
assert_eq!(unselected, " lint echo lint");

crates/vite_task_bin/tests/e2e_snapshots/fixtures/task-list/snapshots/vp run in script.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ expression: e2e_outputs
55
> vp run list-tasks
66
@ expect-milestone: task-select::0
77
$ vp runcache disabled
8-
Select a task (↑/↓, Enter to run, Esc to clear):
8+
Select a task (↑/↓, Enter to run, type to search):
99

1010
hello echo hello from root
1111
list-tasks vp run

crates/vite_task_bin/tests/e2e_snapshots/fixtures/task-select-truncate/snapshots/interactive long command truncated.snap

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,39 +6,39 @@ info:
66
---
77
> vp run
88
@ expect-milestone: task-select::0
9-
Select a task (↑/↓, Enter to run, Esc to clear):
9+
Select a task (↑/↓, Enter to run, type to search):
1010

1111
build echo build app
1212
lint echo lint app
1313
long-cmd echo aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
1414
test echo test app
1515
@ write-key: down
1616
@ expect-milestone: task-select::1
17-
Select a task (↑/↓, Enter to run, Esc to clear):
17+
Select a task (↑/↓, Enter to run, type to search):
1818

1919
build echo build app
2020
lint echo lint app
2121
long-cmd echo aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
2222
test echo test app
2323
@ write-key: down
2424
@ expect-milestone: task-select::2
25-
Select a task (↑/↓, Enter to run, Esc to clear):
25+
Select a task (↑/↓, Enter to run, type to search):
2626

2727
build echo build app
2828
lint echo lint app
2929
long-cmd echo aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
3030
test echo test app
3131
@ write-key: down
3232
@ expect-milestone: task-select::3
33-
Select a task (↑/↓, Enter to run, Esc to clear):
33+
Select a task (↑/↓, Enter to run, type to search):
3434

3535
build echo build app
3636
lint echo lint app
3737
long-cmd echo aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
3838
test echo test app
3939
@ write-key: up
4040
@ expect-milestone: task-select::2
41-
Select a task (↑/↓, Enter to run, Esc to clear):
41+
Select a task (↑/↓, Enter to run, type to search):
4242

4343
build echo build app
4444
lint echo lint app

crates/vite_task_bin/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive enter with no results does nothing.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ info:
66
---
77
> vp run
88
@ expect-milestone: task-select::0
9-
Select a task (↑/↓, Enter to run, Esc to clear):
9+
Select a task (↑/↓, Enter to run, type to search):
1010

1111
build echo build app
1212
lint echo lint app
@@ -23,13 +23,13 @@ Select a task (↑/↓, Enter to run, Esc to clear):
2323
(…5 more)
2424
@ write: zzzzz
2525
@ expect-milestone: task-select:zzzzz:0
26-
Select a task (↑/↓, Enter to run, Esc to clear): zzzzz
26+
Select a task (↑/↓, Enter to run, type to search): zzzzz
2727

2828
No matching tasks.
2929
@ write-key: enter
3030
@ write-key: escape
3131
@ expect-milestone: task-select::0
32-
Select a task (↑/↓, Enter to run, Esc to clear):
32+
Select a task (↑/↓, Enter to run, type to search):
3333

3434
build echo build app
3535
lint echo lint app

crates/vite_task_bin/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive escape clears query.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ info:
66
---
77
> vp run
88
@ expect-milestone: task-select::0
9-
Select a task (↑/↓, Enter to run, Esc to clear):
9+
Select a task (↑/↓, Enter to run, type to search):
1010

1111
build echo build app
1212
lint echo lint app
@@ -23,14 +23,14 @@ Select a task (↑/↓, Enter to run, Esc to clear):
2323
(…5 more)
2424
@ write: lin
2525
@ expect-milestone: task-select:lin:0
26-
Select a task (↑/↓, Enter to run, Esc to clear): lin
26+
Select a task (↑/↓, Enter to run, type to search): lin
2727

2828
lint echo lint app
2929
lib (packages/lib)
3030
lint echo lint lib
3131
@ write-key: escape
3232
@ expect-milestone: task-select::0
33-
Select a task (↑/↓, Enter to run, Esc to clear):
33+
Select a task (↑/↓, Enter to run, type to search):
3434

3535
build echo build app
3636
lint echo lint app

crates/vite_task_bin/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive scroll long list.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ info:
66
---
77
> vp run
88
@ expect-milestone: task-select::0
9-
Select a task (↑/↓, Enter to run, Esc to clear):
9+
Select a task (↑/↓, Enter to run, type to search):
1010

1111
build echo build app
1212
lint echo lint app
@@ -30,7 +30,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
3030
@ write-key: down
3131
@ write-key: down
3232
@ expect-milestone: task-select::8
33-
Select a task (↑/↓, Enter to run, Esc to clear):
33+
Select a task (↑/↓, Enter to run, type to search):
3434

3535
build echo build app
3636
lint echo lint app
@@ -54,7 +54,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
5454
@ write-key: up
5555
@ write-key: up
5656
@ expect-milestone: task-select::0
57-
Select a task (↑/↓, Enter to run, Esc to clear):
57+
Select a task (↑/↓, Enter to run, type to search):
5858

5959
build echo build app
6060
lint echo lint app

crates/vite_task_bin/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive search other package task.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ info:
66
---
77
> vp run
88
@ expect-milestone: task-select::0
9-
Select a task (↑/↓, Enter to run, Esc to clear):
9+
Select a task (↑/↓, Enter to run, type to search):
1010

1111
build echo build app
1212
lint echo lint app
@@ -23,7 +23,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
2323
(…5 more)
2424
@ write: typec
2525
@ expect-milestone: task-select:typec:0
26-
Select a task (↑/↓, Enter to run, Esc to clear): typec
26+
Select a task (↑/↓, Enter to run, type to search): typec
2727

2828
lib (packages/lib)
2929
typecheck echo typecheck lib

crates/vite_task_bin/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive search preserves rating within package.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ info:
66
---
77
> vp run
88
@ expect-milestone: task-select::0
9-
Select a task (↑/↓, Enter to run, Esc to clear):
9+
Select a task (↑/↓, Enter to run, type to search):
1010

1111
build echo build lib
1212
lint echo lint lib
@@ -23,7 +23,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
2323
(…5 more)
2424
@ write: t
2525
@ expect-milestone: task-select:t:0
26-
Select a task (↑/↓, Enter to run, Esc to clear): t
26+
Select a task (↑/↓, Enter to run, type to search): t
2727

2828
test echo test lib
2929
typecheck echo typecheck lib

crates/vite_task_bin/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive search then select.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ info:
66
---
77
> vp run
88
@ expect-milestone: task-select::0
9-
Select a task (↑/↓, Enter to run, Esc to clear):
9+
Select a task (↑/↓, Enter to run, type to search):
1010

1111
build echo build app
1212
lint echo lint app
@@ -23,7 +23,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
2323
(…5 more)
2424
@ write: lin
2525
@ expect-milestone: task-select:lin:0
26-
Select a task (↑/↓, Enter to run, Esc to clear): lin
26+
Select a task (↑/↓, Enter to run, type to search): lin
2727

2828
lint echo lint app
2929
lib (packages/lib)

crates/vite_task_bin/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive search with hash skips reorder.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ info:
66
---
77
> vp run
88
@ expect-milestone: task-select::0
9-
Select a task (↑/↓, Enter to run, Esc to clear):
9+
Select a task (↑/↓, Enter to run, type to search):
1010

1111
build echo build app
1212
lint echo lint app
@@ -23,7 +23,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
2323
(…5 more)
2424
@ write: lib#
2525
@ expect-milestone: task-select:lib#:0
26-
Select a task (↑/↓, Enter to run, Esc to clear): lib#
26+
Select a task (↑/↓, Enter to run, type to search): lib#
2727

2828
lib (packages/lib)
2929
build echo build lib

0 commit comments

Comments
 (0)