fix(task): treat all open errors as NotFound

Author: branchseer

Cargo.lock

@@ -49,11 +49,11 @@ ctor = { workspace = true }
 test-log = { workspace = true }
 tokio = { workspace = true, features = ["rt-multi-thread", "macros", "fs", "io-std"] }
 
-[target.'cfg(all(target_os = "linux", target_arch = "aarch64"))'.dev-dependencies]
-fspy_test_bin = { path = "../fspy_test_bin", artifact = "bin", target = "aarch64-unknown-linux-musl" }
+# [target.'cfg(all(target_os = "linux", target_arch = "aarch64"))'.dev-dependencies]
+# fspy_test_bin = { path = "../fspy_test_bin", artifact = "bin", target = "aarch64-unknown-linux-musl" }
 
-[target.'cfg(all(target_os = "linux", target_arch = "x86_64"))'.dev-dependencies]
-fspy_test_bin = { path = "../fspy_test_bin", artifact = "bin", target = "x86_64-unknown-linux-musl" }
+# [target.'cfg(all(target_os = "linux", target_arch = "x86_64"))'.dev-dependencies]
+# fspy_test_bin = { path = "../fspy_test_bin", artifact = "bin", target = "x86_64-unknown-linux-musl" }
 
 [build-dependencies]
 anyhow = { workspace = true }

crates/fspy/Cargo.toml

@@ -1,9 +1,9 @@
-use std::{ffi::OsString, io, path::Path, sync::Arc};
+use std::{ffi::OsString, io, path::Path};
 
 use fspy::error::SpawnError;
 use petgraph::algo::Cycle;
 use vite_path::{
-    AbsolutePath, RelativePathBuf,
+    RelativePathBuf,
     absolute::StripPrefixError,
     relative::{FromPathError, InvalidPathDataError},
 };
@@ -54,9 +54,6 @@ pub enum Error {
     #[error("The path ({path:?}) is not a valid relative path because: {reason}")]
     InvalidRelativePath { path: Box<Path>, reason: FromPathError },
 
-    #[error("IO error: {err} at {path:?}")]
-    IoWithPath { err: io::Error, path: Arc<AbsolutePath> },
-
     #[cfg(unix)]
     #[error("Unsupported file type: {0:?}")]
     UnsupportedFileType(nix::dir::Type),

crates/vite_task/src/error.rs

@@ -49,6 +49,7 @@ impl FileSystem for RealFileSystem {
 
         let file = match File::open(std_path) {
             Ok(file) => file,
+            #[allow(unused)]
             Err(err) => {
                 // On Windows, File::open fails specifically for directories with PermissionDenied
                 #[cfg(windows)]
@@ -59,17 +60,9 @@ impl FileSystem for RealFileSystem {
                     }
                 }
 
-                return if matches!(
-                    err.kind(),
-                    io::ErrorKind::NotFound |
-                    // A component used as a directory in path is not a directory,
-                    // e.g. "/foo.txt/bar" where "/foo.txt" is a file
-                    io::ErrorKind::NotADirectory
-                ) {
-                    Ok(PathFingerprint::NotFound)
-                } else {
-                    Err(Error::IoWithPath { err, path: path.clone() })
-                };
+                // There are many reasons why opening a file might fail (NotFound, InvalidFilename, NotADirectory, PermissionDenied).
+                // Consider all of them as NotFound for fingerprinting purposes.
+                return Ok(PathFingerprint::NotFound);
             }
         };