Skip to content

Commit 28aa8d9

Browse files
Boshenclaude
andcommitted
fix(ci): pin x64 Node for x86_64-apple-darwin matrix entry
The x86_64-apple-darwin job runs on an arm64 Mac runner under Rosetta. Without explicitly requesting x64 Node, oxc-project/setup-node installs the runner's native arm64 Node and fspy's x86_64 preload dylib can't be injected into spawned node processes, breaking the node_fs tests. Pass architecture: x64 conditionally when matrix.target is the cross target; other targets get the default (runner-native) Node. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent de1aa17 commit 28aa8d9

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,11 @@ jobs:
132132
- name: Run tests
133133
run: ${{ matrix.cargo_cmd }} test --target ${{ matrix.build_target }}
134134

135+
# x86_64-apple-darwin runs on arm64 runner under Rosetta; install x64 Node
136+
# so fspy's x86_64 preload dylib can be injected into spawned node procs.
135137
- uses: oxc-project/setup-node@ab97f03642370d79a7e96dd286bd02a1be40e0ba # v1.3.0
138+
with:
139+
architecture: ${{ matrix.target == 'x86_64-apple-darwin' && 'x64' || '' }}
136140

137141
- name: Run ignored tests
138142
run: ${{ matrix.cargo_cmd }} test --target ${{ matrix.build_target }} -- --ignored

0 commit comments

Comments
 (0)