detect ctrl-c and stdin data

Author: branchseer

crates/fspy/src/lib.rs

@@ -38,6 +38,9 @@ pub struct ChildTermination {
 }
 
 pub struct TrackedChild {
+    /// The process ID of the child.
+    pub pid: u32,
+
     /// The handle for writing to the child's standard input (stdin), if it has
     /// been captured.
     pub stdin: Option<ChildStdin>,

crates/fspy/src/unix/mod.rs

@@ -120,7 +120,11 @@ impl SpyImpl {
             .map_err(|err| SpawnError::OsSpawnError(err.into()))?
             .map_err(SpawnError::OsSpawnError)?;
 
+        // Get the PID before moving child into the wait_handle future
+        let pid = child.id().expect("child process should have a pid");
+
         Ok(TrackedChild {
+            pid,
             stdin: child.stdin.take(),
             stdout: child.stdout.take(),
             stderr: child.stderr.take(),

crates/fspy/src/windows/mod.rs

@@ -130,7 +130,11 @@ impl SpyImpl {
                 }
             })?;
 
+        // Get the PID before moving child into the wait_handle future
+        let pid = child.id().expect("child process should have a pid");
+
         Ok(TrackedChild {
+            pid,
             stdin: child.stdin.take(),
             stdout: child.stdout.take(),
             stderr: child.stderr.take(),

crates/vite_task/Cargo.toml

@@ -29,7 +29,7 @@ rusqlite = { workspace = true, features = ["bundled"] }
 serde = { workspace = true, features = ["derive", "rc"] }
 serde_json = { workspace = true }
 thiserror = { workspace = true }
-tokio = { workspace = true, features = ["rt-multi-thread", "io-std", "macros", "sync"] }
+tokio = { workspace = true, features = ["rt-multi-thread", "io-std", "macros", "sync", "signal"] }
 tracing = { workspace = true }
 twox-hash = { workspace = true }
 vite_glob = { workspace = true }

crates/vite_task/src/session/cache/display.rs

@@ -304,10 +304,16 @@ pub fn format_cache_update_status(status: &CacheUpdateStatus) -> Option<String>
             CacheNotUpdatedReason::CacheHit => None,
             CacheNotUpdatedReason::CacheDisabled => None,
             CacheNotUpdatedReason::BuiltInCommand => None,
-            // This needs to be shown - task failed so cache wasn't updated
+            // These need to be shown - they explain why cache wasn't updated
             CacheNotUpdatedReason::NonZeroExitStatus => {
                 Some("→ Cache not updated: task failed".to_string())
             }
+            CacheNotUpdatedReason::ReceivedCtrlC => {
+                Some("→ Cache not updated: execution interrupted".to_string())
+            }
+            CacheNotUpdatedReason::StdinDataExists => {
+                Some("→ Cache not updated: stdin had data".to_string())
+            }
         },
     }
 }

crates/vite_task/src/session/event.rs

@@ -29,6 +29,10 @@ pub enum CacheNotUpdatedReason {
     NonZeroExitStatus,
     /// Built-in command doesn't support caching
     BuiltInCommand,
+    /// Ctrl+C was received during execution - cache invalidated for safety
+    ReceivedCtrlC,
+    /// Stdin had data - output may depend on input, unsafe to cache
+    StdinDataExists,
 }
 
 #[derive(Debug)]

crates/vite_task/src/session/execute/mod.rs

@@ -287,11 +287,21 @@ impl ExecutionContext<'_> {
         };
 
         // 5. Update cache if successful and determine cache update status
+        // Priority: NonZeroExitStatus > ReceivedCtrlC > StdinDataExists > Success
         let cache_update_status = if let Some((track_result, cache_metadata)) =
             track_result_with_cache_metadata
         {
-            if result.exit_status.success() {
-                // Execution succeeded, attempt cache update
+            if !result.exit_status.success() {
+                // Priority 1: Non-zero exit status - don't update cache
+                CacheUpdateStatus::NotUpdated(CacheNotUpdatedReason::NonZeroExitStatus)
+            } else if result.received_ctrl_c {
+                // Priority 2: Received Ctrl+C - execution was interrupted, unsafe to cache
+                CacheUpdateStatus::NotUpdated(CacheNotUpdatedReason::ReceivedCtrlC)
+            } else if result.stdin_had_data {
+                // Priority 3: Stdin had data - output may depend on input, unsafe to cache
+                CacheUpdateStatus::NotUpdated(CacheNotUpdatedReason::StdinDataExists)
+            } else {
+                // Success: attempt cache update
                 let fingerprint_ignores =
                     cache_metadata.spawn_fingerprint.fingerprint_ignores().map(|v| v.as_slice());
                 match PostRunFingerprint::create(
@@ -326,9 +336,6 @@ impl ExecutionContext<'_> {
                         return Err(ExecutionAborted);
                     }
                 }
-            } else {
-                // Execution failed with non-zero exit status, don't update cache
-                CacheUpdateStatus::NotUpdated(CacheNotUpdatedReason::NonZeroExitStatus)
             }
         } else {
             // Caching was disabled for this task