fix(fspy): correctly report access mode from node:fs on Windows

Author: branchseer

.gitignore

@@ -4,3 +4,4 @@ dist
 .claude/settings.local.json
 *.tsbuildinfo
 .DS_Store
+/.vscode/settings.json

crates/fspy/tests/node_fs.rs

@@ -1,16 +1,20 @@
 mod test_utils;
 
-use std::env::{current_dir, vars_os};
+use std::{
+    env::{current_dir, vars_os},
+    ffi::OsStr,
+};
 
 use fspy::{AccessMode, PathAccessIterable};
 use test_utils::assert_contains;
 
-async fn track_node_script(script: &str) -> anyhow::Result<PathAccessIterable> {
+async fn track_node_script(script: &str, args: &[&OsStr]) -> anyhow::Result<PathAccessIterable> {
     let mut command = fspy::Command::new("node");
     command
         .arg("-e")
         .envs(vars_os()) // https://github.com/jdx/mise/discussions/5968
-        .arg(script);
+        .arg(script)
+        .args(args);
     let child = command.spawn().await?;
     let termination = child.wait_handle.await?;
     assert!(termination.status.success());
@@ -19,14 +23,65 @@ async fn track_node_script(script: &str) -> anyhow::Result<PathAccessIterable> {
 
 #[tokio::test]
 async fn read_sync() -> anyhow::Result<()> {
-    let accesses = track_node_script("try { fs.readFileSync('hello') } catch {}").await?;
+    let accesses = track_node_script("try { fs.readFileSync('hello') } catch {}", &[]).await?;
     assert_contains(&accesses, current_dir().unwrap().join("hello").as_path(), AccessMode::Read);
     Ok(())
 }
 
+#[tokio::test]
+async fn exist_sync() -> anyhow::Result<()> {
+    let accesses = track_node_script("try { fs.existsSync('hello') } catch {}", &[]).await?;
+    assert_contains(&accesses, current_dir().unwrap().join("hello").as_path(), AccessMode::Read);
+    Ok(())
+}
+
+#[tokio::test]
+async fn stat_sync() -> anyhow::Result<()> {
+    let accesses = track_node_script("try { fs.statSync('hello') } catch {}", &[]).await?;
+    assert_contains(&accesses, current_dir().unwrap().join("hello").as_path(), AccessMode::Read);
+    Ok(())
+}
+
+#[tokio::test]
+async fn create_read_stream() -> anyhow::Result<()> {
+    let accesses = track_node_script(
+        "try { fs.createReadStream('hello').on('error', () => {}) } catch {}",
+        &[],
+    )
+    .await?;
+    assert_contains(&accesses, current_dir().unwrap().join("hello").as_path(), AccessMode::Read);
+    Ok(())
+}
+
+#[tokio::test]
+async fn create_write_stream() -> anyhow::Result<()> {
+    let tmpdir = tempfile::tempdir()?;
+    let file_path = tmpdir.path().join("hello");
+    let accesses = track_node_script(
+        "try { fs.createWriteStream(process.argv[1]).on('error', () => {}) } catch {}",
+        &[file_path.as_os_str()],
+    )
+    .await?;
+    assert_contains(&accesses, file_path.as_path(), AccessMode::Write);
+    Ok(())
+}
+
+#[tokio::test]
+async fn write_sync() -> anyhow::Result<()> {
+    let tmpdir = tempfile::tempdir()?;
+    let file_path = tmpdir.path().join("hello");
+    let accesses = track_node_script(
+        "try { fs.writeFileSync(process.argv[1], '') } catch {}",
+        &[file_path.as_os_str()],
+    )
+    .await?;
+    assert_contains(&accesses, &file_path, AccessMode::Write);
+    Ok(())
+}
+
 #[tokio::test]
 async fn read_dir_sync() -> anyhow::Result<()> {
-    let accesses = track_node_script("try { fs.readdirSync('.') } catch {}").await?;
+    let accesses = track_node_script("try { fs.readdirSync('.') } catch {}", &[]).await?;
     assert_contains(&accesses, &current_dir().unwrap(), AccessMode::ReadDir);
     Ok(())
 }
@@ -38,9 +93,10 @@ async fn subprocess() -> anyhow::Result<()> {
     } else {
         r"'/bin/sh', ['-c', 'cat hello']"
     };
-    let accesses = track_node_script(&format!(
-        "try {{ child_process.spawnSync({cmd}, {{ stdio: 'ignore' }}) }} catch {{}}"
-    ))
+    let accesses = track_node_script(
+        &format!("try {{ child_process.spawnSync({cmd}, {{ stdio: 'ignore' }}) }} catch {{}}"),
+        &[],
+    )
     .await?;
     assert_contains(&accesses, current_dir().unwrap().join("hello").as_path(), AccessMode::Read);
     Ok(())

crates/fspy_preload_windows/src/windows/winapi_utils.rs

@@ -12,7 +12,7 @@ use winapi::{
     },
     um::{
         fileapi::GetFinalPathNameByHandleW,
-        winnt::{ACCESS_MASK, GENERIC_READ, GENERIC_WRITE},
+        winnt::{ACCESS_MASK, FILE_APPEND_DATA, FILE_READ_DATA, FILE_WRITE_DATA},
     },
 };
 use winsafe::{GetLastError, co};
@@ -72,8 +72,8 @@ pub unsafe fn get_path_name(handle: HANDLE) -> winsafe::SysResult<SmallVec<u16,
 }
 
 pub fn access_mask_to_mode(desired_access: ACCESS_MASK) -> AccessMode {
-    let has_write = (desired_access & GENERIC_WRITE) != 0;
-    let has_read = (desired_access & GENERIC_READ) != 0;
+    let has_write = (desired_access & (FILE_WRITE_DATA | FILE_APPEND_DATA)) != 0;
+    let has_read = (desired_access & FILE_READ_DATA) != 0;
     if has_write {
         if has_read { AccessMode::ReadWrite } else { AccessMode::Write }
     } else {