refactor: simplify command handling by introducing to_synthetic_plan_request method

Author: branchseer

crates/vite_task/src/session/mod.rs

@@ -98,12 +98,9 @@ impl vite_task_plan::PlanRequestParser for PlanRequestParser<'_> {
         match self.command_handler.handle_command(command).await? {
             HandledCommand::Synthesized(synthetic) => Ok(Some(PlanRequest::Synthetic(synthetic))),
             HandledCommand::ViteTaskCommand(cli_command) => match cli_command {
-                Command::Cache { .. } => Ok(Some(PlanRequest::Synthetic(SyntheticPlanRequest {
-                    program: Arc::from(OsStr::new(command.program.as_str())),
-                    args: Arc::clone(&command.args),
-                    cache_config: UserCacheConfig::disabled(),
-                    envs: Arc::clone(&command.envs),
-                }))),
+                Command::Cache { .. } => Ok(Some(PlanRequest::Synthetic(
+                    command.to_synthetic_plan_request(UserCacheConfig::disabled()),
+                ))),
                 Command::Run(run_command) => Ok(Some(run_command.into_plan_request(&command.cwd)?)),
             },
             HandledCommand::Verbatim => Ok(None),

crates/vite_task_plan/src/plan_request.rs

@@ -18,6 +18,18 @@ pub struct ScriptCommand {
     pub cwd: Arc<AbsolutePath>,
 }
 
+impl ScriptCommand {
+    /// Convert this `ScriptCommand` to a `PlanRequest::Synthetic` with the given `cache_config`.
+    pub fn to_synthetic_plan_request(&self, cache_config: UserCacheConfig) -> SyntheticPlanRequest {
+        SyntheticPlanRequest {
+            program: Arc::from(OsStr::new(&self.program)),
+            args: self.args.clone(),
+            cache_config,
+            envs: self.envs.clone(),
+        }
+    }
+}
+
 #[derive(Debug)]
 pub struct PlanOptions {
     pub extra_args: Arc<[Str]>,