refactor: remove interact subcommand and increase task select page size to 12

Remove the vp interact subcommand and interactions-no-vp test fixture
as they are no longer needed. Remove crossterm and pty_terminal_test_client
dependencies from vite_task_bin that were only used by the interact command.

Increase interactive task select page_size from 8 to 12. Add extra tasks
to the task-select fixture to ensure paging behavior is still tested.

Author: branchseer

Cargo.lock

@@ -356,7 +356,7 @@ impl<'a> Session<'a> {
             items: &select_items,
             query: not_found_name,
             header: header.as_deref(),
-            page_size: 8,
+            page_size: 12,
         };
 
         vite_select::select_list(

crates/vite_task/src/session/mod.rs

@@ -14,9 +14,7 @@ path = "src/main.rs"
 anyhow = { workspace = true }
 async-trait = { workspace = true }
 clap = { workspace = true, features = ["derive"] }
-crossterm = { workspace = true }
 jsonc-parser = { workspace = true }
-pty_terminal_test_client = { workspace = true }
 rustc-hash = { workspace = true }
 serde_json = { workspace = true }
 tokio = { workspace = true, features = ["full"] }

crates/vite_task_bin/Cargo.toml

@@ -84,7 +84,6 @@ pub enum Args {
         name: Str,
         value: Str,
     },
-    Interact,
     #[command(flatten)]
     Task(Command),
 }
@@ -131,7 +130,6 @@ impl vite_task::CommandHandler for CommandHandler {
                     envs: Arc::new(envs),
                 }))
             }
-            Args::Interact => Ok(HandledCommand::Verbatim),
             Args::Task(cli_command) => Ok(HandledCommand::ViteTaskCommand(cli_command)),
         }
     }

crates/vite_task_bin/src/lib.rs

@@ -1,8 +1,4 @@
-use std::{
-    io::{IsTerminal, Read, Write},
-    process::ExitCode,
-    sync::Arc,
-};
+use std::{process::ExitCode, sync::Arc};
 
 use clap::Parser;
 use vite_str::Str;
@@ -25,7 +21,6 @@ async fn run() -> anyhow::Result<ExitStatus> {
     let mut owned_callbacks = OwnedSessionCallbacks::default();
     let session = Session::init(owned_callbacks.as_callbacks())?;
     match args {
-        Args::Interact => run_interact(),
         Args::Task(command) => {
             #[expect(clippy::large_futures, reason = "session.main produces a large future")]
             {
@@ -67,155 +62,3 @@ async fn run() -> anyhow::Result<ExitStatus> {
         }
     }
 }
-
-fn write_line(stdout: &mut impl Write, line: &[u8]) -> anyhow::Result<()> {
-    stdout.write_all(line)?;
-    stdout.write_all(b"\r\n")?;
-    stdout.flush()?;
-    Ok(())
-}
-
-fn write_milestone(stdout: &mut impl Write, name: &str) -> anyhow::Result<()> {
-    stdout.write_all(&pty_terminal_test_client::encoded_milestone(name))?;
-    stdout.flush()?;
-    Ok(())
-}
-
-struct RawModeGuard {
-    enabled: bool,
-}
-
-impl RawModeGuard {
-    fn new(enabled: bool) -> anyhow::Result<Self> {
-        if enabled {
-            crossterm::terminal::enable_raw_mode()?;
-        }
-        Ok(Self { enabled })
-    }
-
-    fn disable(&mut self) -> anyhow::Result<()> {
-        if self.enabled {
-            crossterm::terminal::disable_raw_mode()?;
-            self.enabled = false;
-        }
-        Ok(())
-    }
-}
-
-impl Drop for RawModeGuard {
-    fn drop(&mut self) {
-        if self.enabled {
-            let _ = crossterm::terminal::disable_raw_mode();
-        }
-    }
-}
-
-fn run_interact() -> anyhow::Result<ExitStatus> {
-    let stdin_is_tty = std::io::stdin().is_terminal();
-    let enable_raw_mode = if cfg!(windows) { true } else { stdin_is_tty };
-    let mut raw_mode = RawModeGuard::new(enable_raw_mode)?;
-
-    let mut stdin = std::io::stdin();
-    let mut stdout = std::io::stdout();
-    let mut text_buffer = Vec::<u8>::new();
-    let mut ansi_escape_pending = false;
-    let mut ansi_csi_pending = false;
-    let mut windows_extended_key_pending = false;
-
-    write_line(&mut stdout, b"START")?;
-    write_milestone(&mut stdout, "ready")?;
-
-    loop {
-        let mut byte = [0u8; 1];
-        let read_count = stdin.read(&mut byte)?;
-        if read_count == 0 {
-            break;
-        }
-
-        let byte = byte[0];
-        if ansi_escape_pending {
-            ansi_escape_pending = false;
-
-            if byte == b'[' || byte == b'O' {
-                ansi_csi_pending = true;
-                continue;
-            }
-        }
-
-        if ansi_csi_pending {
-            ansi_csi_pending = false;
-
-            if byte == b'A' {
-                write_milestone(&mut stdout, "after-up")?;
-                continue;
-            }
-
-            if byte == b'B' {
-                write_milestone(&mut stdout, "after-down")?;
-                continue;
-            }
-        }
-
-        if windows_extended_key_pending {
-            windows_extended_key_pending = false;
-
-            if byte == 72 {
-                write_milestone(&mut stdout, "after-up")?;
-                continue;
-            }
-
-            if byte == 80 {
-                write_milestone(&mut stdout, "after-down")?;
-                continue;
-            }
-        }
-
-        if byte == 0x1b {
-            ansi_escape_pending = true;
-            continue;
-        }
-
-        if byte == 0x00 || byte == 0xe0 {
-            windows_extended_key_pending = true;
-            continue;
-        }
-
-        if byte == b'\r' {
-            if text_buffer.is_empty() {
-                write_line(&mut stdout, b"KEY:ENTER")?;
-                raw_mode.disable()?;
-                write_line(&mut stdout, b"DONE")?;
-                write_milestone(&mut stdout, "after-enter")?;
-                return Ok(ExitStatus::SUCCESS);
-            }
-
-            stdout.write_all(b"LINE:")?;
-            stdout.write_all(&text_buffer)?;
-            stdout.write_all(b"\r\n")?;
-            stdout.flush()?;
-            text_buffer.clear();
-            write_milestone(&mut stdout, "after-line")?;
-            continue;
-        }
-
-        if byte == b'\n' {
-            if !text_buffer.is_empty() {
-                stdout.write_all(b"LINE:")?;
-                stdout.write_all(&text_buffer)?;
-                stdout.write_all(b"\r\n")?;
-                stdout.flush()?;
-                text_buffer.clear();
-                write_milestone(&mut stdout, "after-line")?;
-            }
-            continue;
-        }
-
-        text_buffer.push(byte);
-        stdout.write_all(b"CHAR:")?;
-        stdout.write_all(&[byte])?;
-        stdout.write_all(b"\r\n")?;
-        stdout.flush()?;
-    }
-
-    Ok(ExitStatus::SUCCESS)
-}

crates/vite_task_bin/src/main.rs

@@ -13,7 +13,11 @@ Search task (↑/↓ to move, enter to select):
   lib#test: echo test lib
   lib#typecheck: echo typecheck lib
   task-select-test#check: echo check root
-  (…4 more)
+  task-select-test#clean: echo clean root
+  task-select-test#deploy: echo deploy root
+  task-select-test#docs: echo docs root
+  task-select-test#format: echo format root
+  (…3 more)
 @ write: lin
 @ expect-milestone: task-select:lin:0
 Search task (↑/↓ to move, enter to select): lin
@@ -30,7 +34,11 @@ Search task (↑/↓ to move, enter to select):
   lib#test: echo test lib
   lib#typecheck: echo typecheck lib
   task-select-test#check: echo check root
-  (…4 more)
+  task-select-test#clean: echo clean root
+  task-select-test#deploy: echo deploy root
+  task-select-test#docs: echo docs root
+  task-select-test#format: echo format root
+  (…3 more)
 @ write-key: enter
 ~/packages/app$ echo build app ⊘ cache disabled: built-in command
 build app

crates/vite_task_bin/tests/e2e_snapshots/fixtures/interactions-no-vp/package.json

@@ -13,7 +13,11 @@ Search task (↑/↓ to move, enter to select):
   lib#test: echo test lib
   lib#typecheck: echo typecheck lib
   task-select-test#check: echo check root
-  (…4 more)
+  task-select-test#clean: echo clean root
+  task-select-test#deploy: echo deploy root
+  task-select-test#docs: echo docs root
+  task-select-test#format: echo format root
+  (…3 more)
 @ write-key: down
 @ write-key: down
 @ write-key: down
@@ -24,14 +28,18 @@ Search task (↑/↓ to move, enter to select):
 @ write-key: down
 @ expect-milestone: task-select::8
 Search task (↑/↓ to move, enter to select):
+  build: echo build app
   lint: echo lint app
   test: echo test app
   lib#build: echo build lib
   lib#lint: echo lint lib
   lib#test: echo test lib
   lib#typecheck: echo typecheck lib
   task-select-test#check: echo check root
-> task-select-test#format: echo format root
+> task-select-test#clean: echo clean root
+  task-select-test#deploy: echo deploy root
+  task-select-test#docs: echo docs root
+  task-select-test#format: echo format root
   (…3 more)
 @ write-key: up
 @ write-key: up
@@ -51,7 +59,11 @@ Search task (↑/↓ to move, enter to select):
   lib#test: echo test lib
   lib#typecheck: echo typecheck lib
   task-select-test#check: echo check root
-  (…4 more)
+  task-select-test#clean: echo clean root
+  task-select-test#deploy: echo deploy root
+  task-select-test#docs: echo docs root
+  task-select-test#format: echo format root
+  (…3 more)
 @ write-key: enter
 ~/packages/app$ echo build app ⊘ cache disabled: built-in command
 build app