Commit 3e37fef
fix(client): bypass interprocess linger pool on Drop (Windows)
The runner-aware addon's e2e fixtures (`ipc_client_test`,
`vite_build_cache`, `vite_dev_disable_cache`) all carry
`platform = "unix"` with the note that on Windows CI the Node child
aborts with `failed to start the persistent thread of the Interprocess
linger pool: Access is denied` when the napi addon tears down. The
panic comes from `interprocess::os::windows::named_pipe::stream::Drop`
handing dirty pipes to a lazily-spawned background thread that calls
`FlushFileBuffers` for graceful close. Windows CI containers refuse
the `CreateThread` from inside Node's worker-thread finalizer with
ACCESS_DENIED, the crate `expect`s on that path, and the panic kills
the child.
Add a `Drop` impl for `Client` that, on Windows, reaches into the
underlying `DuplexPipeStream` via `local_socket::Stream::NamedPipe(_)`
and calls `assume_flushed()` so the inner stream's `Drop` skips the
limbo detour. The IPC is strictly request/response, so once we have
read each response the server has already consumed every byte we sent
— there is nothing to flush at close time anyway.
The fix unblocks Windows CI for every test that goes through the
addon. Drop `platform = "unix"` from all nine `[[e2e]]` cases that
were gated on the bug; they remain `ignore = true` because they still
need a pnpm-populated `node_modules` to run.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 8f43e16 commit 3e37fef
4 files changed
Lines changed: 24 additions & 36 deletions
File tree
- crates
- vite_task_bin/tests/e2e_snapshots/fixtures
- ipc_client_test
- vite_build_cache
- vite_dev_disable_cache
- vite_task_client/src
Lines changed: 0 additions & 20 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | 8 | | |
13 | 9 | | |
14 | 10 | | |
| |||
36 | 32 | | |
37 | 33 | | |
38 | 34 | | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | 35 | | |
44 | 36 | | |
45 | 37 | | |
| |||
70 | 62 | | |
71 | 63 | | |
72 | 64 | | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | 65 | | |
78 | 66 | | |
79 | 67 | | |
| |||
96 | 84 | | |
97 | 85 | | |
98 | 86 | | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | 87 | | |
104 | 88 | | |
105 | 89 | | |
| |||
213 | 197 | | |
214 | 198 | | |
215 | 199 | | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | 200 | | |
221 | 201 | | |
222 | 202 | | |
| |||
Lines changed: 0 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | 6 | | |
11 | 7 | | |
12 | 8 | | |
| |||
43 | 39 | | |
44 | 40 | | |
45 | 41 | | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | 42 | | |
51 | 43 | | |
52 | 44 | | |
| |||
113 | 105 | | |
114 | 106 | | |
115 | 107 | | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | 108 | | |
121 | 109 | | |
122 | 110 | | |
| |||
Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | 6 | | |
11 | 7 | | |
12 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
19 | 43 | | |
20 | 44 | | |
21 | 45 | | |
| |||
0 commit comments