feat: improve file parsing error display

Author: branchseer

crates/vite_task_graph/src/lib.rs

@@ -88,7 +88,7 @@ impl vite_graph_ser::GetKey for TaskNode {
 
 #[derive(Debug, thiserror::Error)]
 pub enum TaskGraphLoadError {
-    #[error("Failed to load package graph: {0}")]
+    #[error("Failed to load package graph")]
     PackageGraphLoadError(#[from] vite_workspace::Error),
 
     #[error("Failed to load task config file for package at {package_path:?}")]

crates/vite_task_plan/src/context.rs

@@ -64,12 +64,14 @@ pub struct TaskCallStackDisplay {
     frames: Arc<[TaskCallStackFrameDisplay]>,
 }
 
+impl TaskCallStackDisplay {
+    pub fn is_empty(&self) -> bool {
+        self.frames.is_empty()
+    }
+}
+
 impl Display for TaskCallStackDisplay {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        if self.frames.is_empty() {
-            write!(f, "<empty>")?;
-            return Ok(());
-        }
         for (i, frame) in self.frames.iter().enumerate() {
             if i > 0 {
                 write!(f, " -> ")?;

crates/vite_task_plan/src/error.rs

@@ -126,14 +126,23 @@ pub enum TaskPlanErrorKind {
 }
 
 #[derive(Debug, thiserror::Error)]
-#[error("Failed to plan execution, task call stack: {task_call_stack}")]
 pub struct Error {
     task_call_stack: TaskCallStackDisplay,
 
     #[source]
     kind: TaskPlanErrorKind,
 }
 
+impl Display for Error {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        write!(f, "Failed to plan execution")?;
+        if !self.task_call_stack.is_empty() {
+            write!(f, ", task call stack: {}", self.task_call_stack)?
+        }
+        Ok(())
+    }
+}
+
 impl TaskPlanErrorKind {
     pub fn with_empty_call_stack(self) -> Error {
         Error { task_call_stack: TaskCallStackDisplay::default(), kind: self }