ci(test): keep coverage in scope, drop VT_SKIP_E2E

The non-e2e Windows scope is now `--workspace --exclude vite_task_bin`
and the e2e scope stays `-p vite_task_bin --test e2e_snapshots`. Together
they cover the whole workspace, looking only at the scope fields.

The risk that --exclude vite_task_bin silently drops future tests is
closed by tightening vite_task_bin's Cargo.toml: lib/doc were already
test=false, and the two [[bin]] entries now set test=false too. A
comment on [[test]] flags that adding another test target there would
escape CI, so any future contributor has to either update the workflow
or add the test to a different crate.

Author: claude

.github/workflows/ci.yml

@@ -96,9 +96,11 @@ jobs:
             run_env: ''
           # Windows e2e fixtures dominate wall-clock (60s per PTY step vs 20s on
           # Unix). Sharded 5 ways at the trial level by the e2e harness via
-          # VT_SHARD_INDEX/VT_SHARD_TOTAL. The non-e2e shard uses --workspace
-          # (self-evidently covers everything) and relies on VT_SKIP_E2E in the
-          # e2e harness to suppress the already-sharded work.
+          # VT_SHARD_INDEX/VT_SHARD_TOTAL. Coverage is partitioned by scope:
+          # the e2e shards select only `-p vite_task_bin --test e2e_snapshots`,
+          # and the non-e2e shard runs `--workspace --exclude vite_task_bin`.
+          # vite_task_bin's Cargo.toml disables lib/doc/bin tests so the only
+          # test in the excluded crate is e2e_snapshots itself.
           - os: windows-latest
             target: x86_64-pc-windows-msvc
             cargo_cmd: cargo
@@ -139,8 +141,8 @@ jobs:
             cargo_cmd: cargo
             build_target: x86_64-pc-windows-msvc
             shard: windows-non-e2e
-            scope: ''
-            run_env: 'VT_SKIP_E2E=1'
+            scope: '--workspace --exclude vite_task_bin'
+            run_env: ''
     runs-on: ${{ matrix.os }}
     steps:
       - uses: taiki-e/checkout-action@7d1e50e93dc4fb3bba58f85018fadf77898aee8b # v1.4.2

crates/vite_task_bin/Cargo.toml

@@ -10,10 +10,15 @@ rust-version.workspace = true
 [[bin]]
 name = "vt"
 path = "src/main.rs"
+# This crate is excluded from CI's non-e2e Windows shard via
+# `cargo test --workspace --exclude vite_task_bin`, so any unit tests
+# here would be silently dropped. Keep them out.
+test = false
 
 [[bin]]
 name = "vtt"
 path = "src/vtt/main.rs"
+test = false
 
 [dependencies]
 anyhow = { workspace = true }
@@ -58,6 +63,10 @@ ignored = ["preload_test_lib"]
 [lints]
 workspace = true
 
+# Only one [[test]] should live in this crate. CI shards the e2e
+# binary across 5 Windows jobs and runs `--workspace --exclude
+# vite_task_bin` everywhere else, so any additional [[test]] here
+# would be silently dropped from non-Windows-e2e jobs.
 [[test]]
 name = "e2e_snapshots"
 harness = false

crates/vite_task_bin/tests/e2e_snapshots/main.rs

@@ -571,13 +571,6 @@ fn parse_shard_env() -> Option<(usize, usize)> {
 
 #[expect(clippy::disallowed_types, reason = "Path required for CARGO_MANIFEST_DIR path traversal")]
 fn main() {
-    // Bypass for the non-e2e Windows shard: cargo still launches this binary
-    // as part of `cargo test --workspace`, but the e2e cases are sharded by
-    // the windows-e2e-* jobs, so we exit immediately.
-    if std::env::var_os("VT_SKIP_E2E").is_some() {
-        return;
-    }
-
     let tmp_dir = tempfile::tempdir().unwrap();
     let tmp_dir_path = AbsolutePathBuf::new(tmp_dir.path().canonicalize().unwrap()).unwrap();