Skip to content

Commit 7a3bf10

Browse files
committed
chore: clean up after object dependsOn reverts
The mechanical reverts of #467 and #469 could not account for changes that landed on main afterwards: - #477 renamed plan task-graph snapshots from `.jsonc` to `.md`, so reverting the `depends_on_package_dependencies` fixture left `snapshots/task_graph.md` behind as an orphan with no package. The plan snapshot harness runs every fixture directory through workspace discovery, so this stale directory would fail the suite — remove it. - `vec1` was used only by the reverted object-form `dependsOn` config, so it is now an unused dependency of `vite_task_graph` that `cargo shear` rejects — drop it. - Reverting #467's `task-query.md` edits would reintroduce the internal `vite-task.json` name into published docs; keep the public `vite.config.*` spelling that main already uses. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QowxsN8vDKKbQdaSMdxL67
1 parent 425e3ae commit 7a3bf10

4 files changed

Lines changed: 3 additions & 1011 deletions

File tree

Cargo.lock

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/vite_task/docs/task-query.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ How `vp run` decides which tasks to run and in what order.
77
When `vp` starts, it builds two data structures from the workspace:
88

99
1. **Package graph** — which packages depend on which. Built from `package.json` dependency fields.
10-
2. **Task graph** — which tasks exist and their explicit `dependsOn` relationships. Built from `vite-task.json` and `package.json` scripts.
10+
2. **Task graph** — which tasks exist and their explicit `dependsOn` relationships. Built from `vite.config.*` and `package.json` scripts.
1111

1212
Both are built once and reused for every query, including nested `vp run` calls inside task scripts.
1313

@@ -16,7 +16,7 @@ Both are built once and reused for every query, including nested `vp run` calls
1616
The task graph contains a node for every task in every package, and edges only for explicit `dependsOn` declarations:
1717

1818
```jsonc
19-
// packages/app/vite-task.json
19+
// packages/app/vite.config.*
2020
{
2121
"tasks": {
2222
"build": {
@@ -174,7 +174,7 @@ So we clone the `DiGraphMap` once and mutate the clone. We iterate the original
174174
After mapping the package subgraph to tasks, we follow explicit `dependsOn` edges from the task graph. This can pull in tasks from packages outside the selected set.
175175

176176
```jsonc
177-
// packages/app/vite-task.json
177+
// packages/app/vite.config.*
178178
{
179179
"tasks": {
180180
"build": {

crates/vite_task_graph/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ serde = { workspace = true, features = ["derive"] }
1818
serde_json = { workspace = true }
1919
thiserror = { workspace = true }
2020
tracing = { workspace = true }
21-
vec1 = { workspace = true, features = ["serde"] }
2221
vite_path = { workspace = true }
2322
vite_str = { workspace = true }
2423
vite_workspace = { workspace = true }

0 commit comments

Comments
 (0)