chore: fix all clippy issues

 (#147)

Resolve all errors from `cargo clippy --workspace --all-targets --all-features -- --deny warnings`
across every crate.

Author: wan9chi

.cargo/config.toml

@@ -3,3 +3,11 @@ rustflags = ["--cfg", "tokio_unstable"] # also update .github/workflows/ci.yml
 
 [unstable]
 bindeps = true
+
+# Linker wrappers for cross-compiling bindep targets (fspy_test_bin) via cargo-zigbuild.
+# On native Linux the system linker can handle musl targets; these are needed on non-Linux hosts.
+[target.x86_64-unknown-linux-musl]
+rustflags = ["-C", "linker=.cargo/zigcc-x86_64-unknown-linux-musl"]
+
+[target.aarch64-unknown-linux-musl]
+rustflags = ["-C", "linker=.cargo/zigcc-aarch64-unknown-linux-musl"]

.cargo/zigcc-aarch64-unknown-linux-musl

@@ -0,0 +1,2 @@
+#!/bin/sh
+exec cargo-zigbuild zig cc -- -fno-sanitize=all -target aarch64-linux-musl "$@"

.cargo/zigcc-x86_64-unknown-linux-musl

@@ -0,0 +1,2 @@
+#!/bin/sh
+exec cargo-zigbuild zig cc -- -fno-sanitize=all -target x86_64-linux-musl "$@"

.github/workflows/ci.yml

@@ -50,6 +50,7 @@ jobs:
         with:
           save-cache: ${{ github.ref_name == 'main' }}
           cache-key: test
+          components: clippy
 
       - run: rustup target add ${{ matrix.target }}
 
@@ -63,6 +64,8 @@ jobs:
         env:
           RUSTFLAGS: '-D warnings --cfg tokio_unstable' # also update .cargo/config.toml
 
+      - run: cargo clippy --all-targets --all-features -- -D warnings
+
       # Set up node and pnpm for running tests
       # For x86_64-apple-darwin, use x64 node for fspy tests that verify Node.js fs accesses
       - uses: actions/setup-node@395ad3262231945c25e8478fd5baf05154b1d79f # v6.1.0
@@ -84,8 +87,8 @@ jobs:
       - run: cargo-zigbuild test --target x86_64-unknown-linux-gnu.2.17
         if: ${{ matrix.os == 'ubuntu-latest' }}
 
-  lint:
-    name: Lint
+  fmt:
+    name: Format and Check Deps
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -96,14 +99,13 @@ jobs:
       - uses: oxc-project/setup-rust@d286d43bc1f606abbd98096666ff8be68c8d5f57 # v1.0.0
         with:
           save-cache: ${{ github.ref_name == 'main' }}
-          cache-key: lint
+          cache-key: fmt
           tools: dprint,cargo-shear
           components: clippy rust-docs rustfmt
 
       - run: dprint check
       - run: cargo shear
       - run: cargo fmt --check
-      # - run: cargo clippy --all-targets --all-features -- -D warnings
       - run: RUSTDOCFLAGS='-D warnings' cargo doc --no-deps --document-private-items
 
       - uses: crate-ci/typos@85f62a8a84f939ae994ab3763f01a0296d61a7ee # v1.36.2
@@ -119,7 +121,7 @@ jobs:
     runs-on: ubuntu-latest
     needs:
       - test
-      - lint
+      - fmt
     steps:
       - run: exit 1
         # Thank you, next https://github.com/vercel/next.js/blob/canary/.github/workflows/build_and_test.yml#L379

.rustfmt.toml

@@ -16,3 +16,8 @@ reorder_impl_items = true
 group_imports = "StdExternalCrate"
 # Group "use" statements by crate
 imports_granularity = "Crate"
+
+# Skip generated files
+ignore = [
+  "crates/fspy_detours_sys/src/generated_bindings.rs",
+]

CLAUDE.md

@@ -13,6 +13,8 @@ just fmt           # Format code (cargo fmt, cargo shear, dprint)
 just check         # Check compilation with all features
 just test          # Run all tests
 just lint          # Clippy linting
+just lint-linux    # Cross-clippy for Linux (requires cargo-zigbuild)
+just lint-windows  # Cross-clippy for Windows (requires cargo-xwin)
 just doc           # Documentation generation
 ```
 
@@ -88,6 +90,16 @@ Tasks are defined in `vite-task.json`:
    - With `-r/--recursive`: runs task across all packages in dependency order
    - With `-t/--transitive`: runs task in current package and its dependencies
 
+## Cross-Platform Linting
+
+After major changes (especially to `fspy*` or platform-specific crates), run cross-platform clippy before pushing:
+
+```bash
+just lint          # native (host platform)
+just lint-linux    # Linux via cargo-zigbuild
+just lint-windows  # Windows via cargo-xwin
+```
+
 ## Code Constraints
 
 These patterns are enforced by `.clippy.toml`:

Cargo.lock

@@ -27,10 +27,13 @@ unimplemented = "warn"
 print_stdout = "warn"
 print_stderr = "warn"
 allow_attributes = "warn"
+allow_attributes_without_reason = "warn"
+undocumented_unsafe_blocks = "warn"
 pedantic = { level = "warn", priority = -1 }
 nursery = { level = "warn", priority = -1 }
 cargo = { level = "warn", priority = -1 }
 cargo_common_metadata = "allow"
+multiple_crate_versions = "allow"
 
 [workspace.dependencies]
 allocator-api2 = { version = "0.2.21", default-features = false, features = ["alloc", "std"] }

Cargo.toml

@@ -1,3 +1,10 @@
+#![allow(
+    clippy::disallowed_types,
+    clippy::disallowed_methods,
+    clippy::disallowed_macros,
+    reason = "non-vite crate"
+)]
+
 use std::{
     env::{self, current_dir},
     fs,
@@ -21,7 +28,7 @@ fn download(url: &str) -> anyhow::Result<impl Read + use<>> {
     let output = curl.wait_with_output()?;
     if !output.status.success() {
         bail!("curl exited with status {} trying to download {}", output.status, url);
-    };
+    }
     Ok(Cursor::new(output.stdout))
 }
 
@@ -50,19 +57,22 @@ fn download_and_unpack_tar_gz(url: &str, path: &str) -> anyhow::Result<Vec<u8>>
     Ok(data)
 }
 
-const MACOS_BINARY_DOWNLOADS: &[(&str, &[(&str, &str, u128)])] = &[
+/// (url, `path_in_targz`, `expected_hash`)
+type BinaryDownload = (&'static str, &'static str, u128);
+
+const MACOS_BINARY_DOWNLOADS: &[(&str, &[BinaryDownload])] = &[
     (
         "aarch64",
         &[
             (
                 "https://github.com/branchseer/oils-for-unix-build/releases/download/oils-for-unix-0.37.0/oils-for-unix-0.37.0-darwin-arm64.tar.gz",
                 "oils-for-unix",
-                282073174065923237490435663309538399576,
+                282_073_174_065_923_237_490_435_663_309_538_399_576,
             ),
             (
                 "https://github.com/uutils/coreutils/releases/download/0.4.0/coreutils-0.4.0-aarch64-apple-darwin.tar.gz",
                 "coreutils-0.4.0-aarch64-apple-darwin/coreutils",
-                35998406686137668997937014088186935383,
+                35_998_406_686_137_668_997_937_014_088_186_935_383,
             ),
         ],
     ),
@@ -72,12 +82,12 @@ const MACOS_BINARY_DOWNLOADS: &[(&str, &[(&str, &str, u128)])] = &[
             (
                 "https://github.com/branchseer/oils-for-unix-build/releases/download/oils-for-unix-0.37.0/oils-for-unix-0.37.0-darwin-x86_64.tar.gz",
                 "oils-for-unix",
-                142673558272427867831039361796426010330,
+                142_673_558_272_427_867_831_039_361_796_426_010_330,
             ),
             (
                 "https://github.com/uutils/coreutils/releases/download/0.4.0/coreutils-0.4.0-x86_64-apple-darwin.tar.gz",
                 "coreutils-0.4.0-x86_64-apple-darwin/coreutils",
-                120898281113671104995723556995187526689,
+                120_898_281_113_671_104_995_723_556_995_187_526_689,
             ),
         ],
     ),

crates/fspy/build.rs

@@ -1,3 +1,10 @@
+#![allow(
+    clippy::disallowed_types,
+    clippy::disallowed_methods,
+    clippy::disallowed_macros,
+    reason = "non-vite crate"
+)]
+
 use std::{env::args_os, ffi::OsStr, path::PathBuf, pin::Pin};
 
 use tokio::{
@@ -29,15 +36,22 @@ async fn main() -> anyhow::Result<()> {
 
     for acc in termination.path_accesses.iter() {
         path_count += 1;
+        let mode_str = format!("{:?}", acc.mode);
         csv_writer
             .write_record(&[
                 acc.path.to_cow_os_str().to_string_lossy().as_ref().as_bytes(),
-                format!("{:?}", acc.mode).as_bytes(),
+                mode_str.as_bytes(),
             ])
             .await?;
     }
     csv_writer.flush().await?;
 
-    eprintln!("\nfspy: {path_count} paths accessed. status: {}", termination.status);
+    #[expect(
+        clippy::print_stderr,
+        reason = "CLI example: stderr output is intentional for user feedback"
+    )]
+    {
+        eprintln!("\nfspy: {path_count} paths accessed. status: {}", termination.status);
+    }
     Ok(())
 }