Fix milestone screen sanitization clippy lint

branchseer · branchseer · commit 8e4622a23222 · 2026-02-11T23:41:53.000+08:00
diff --git a/crates/pty_terminal_test/src/lib.rs b/crates/pty_terminal_test/src/lib.rs
@@ -46,7 +46,9 @@ impl TestTerminal {
 
 impl Reader {
     fn sanitized_screen_contents(&self) -> String {
-        self.pty.get_ref().screen_contents().replace(MILESTONE_FENCE_CHAR, "")
+        let mut screen = self.pty.get_ref().screen_contents();
+        screen.retain(|ch| ch != MILESTONE_FENCE_CHAR);
+        screen
     }
 
     /// Reads from the PTY until a milestone with the given name is encountered.

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,9 @@ impl TestTerminal {`
`46`	`46`
`47`	`47`	`impl Reader {`
`48`	`48`	`fn sanitized_screen_contents(&self) -> String {`
`49`		`- self.pty.get_ref().screen_contents().replace(MILESTONE_FENCE_CHAR, "")`
	`49`	`+ let mut screen = self.pty.get_ref().screen_contents();`
	`50`	`+ screen.retain(\|ch\| ch != MILESTONE_FENCE_CHAR);`
	`51`	`+ screen`
`50`	`52`	`}`
`51`	`53`
`52`	`54`	`/// Reads from the PTY until a milestone with the given name is encountered.`