Skip to content

Commit 96182ea

Browse files
committed
Revert "test: add --verbose to all e2e test runs to prove full summary output is unchanged"
This reverts commit 86019bc.
1 parent 86019bc commit 96182ea

File tree

55 files changed

+134
-134
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+134
-134
lines changed

crates/vite_task/src/cli/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ pub struct RunFlags {
3232
pub ignore_depends_on: bool,
3333

3434
/// Show full detailed summary after execution.
35-
#[clap(default_value = "false", short = 'v', long)]
36-
pub verbose: bool,
35+
#[clap(default_value = "false", long)]
36+
pub details: bool,
3737
}
3838

3939
// ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

crates/vite_task/src/session/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ impl<'a> Session<'a> {
237237

238238
// Save task name and flags before consuming run_command
239239
let task_name = run_command.task_specifier.as_ref().map(|s| s.task_name.clone());
240-
let show_details = run_command.flags.verbose;
240+
let show_details = run_command.flags.details;
241241
let flags = run_command.flags;
242242
let additional_args = run_command.additional_args.clone();
243243

@@ -398,7 +398,7 @@ impl<'a> Session<'a> {
398398
// Interactive: run the selected task
399399
let selected_label = &select_items[selected_index].label;
400400
let task_specifier = TaskSpecifier::parse_raw(selected_label);
401-
let show_details = flags.verbose;
401+
let show_details = flags.details;
402402
let run_command =
403403
RunCommand { task_specifier: Some(task_specifier), flags, additional_args };
404404

crates/vite_task/src/session/reporter/labeled.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,12 @@ struct SharedReporterState {
4949
/// - Single task + cache hit → thin line + "[vp run] cache hit, {duration} saved."
5050
/// - Multi-task → thin line + one-liner with stats
5151
///
52-
/// ## Full Summary (`--verbose`)
52+
/// ## Full Summary (`--details`)
5353
/// - Shows full Statistics, Performance, and Task Details sections
5454
pub struct LabeledReporterBuilder {
5555
workspace_path: Arc<AbsolutePath>,
5656
writer: Box<dyn AsyncWrite + Unpin>,
57-
/// Whether to render the full detailed summary (`--verbose` flag).
57+
/// Whether to render the full detailed summary (`--details` flag).
5858
show_details: bool,
5959
/// Callback to persist the summary (e.g., write `last-summary.json`).
6060
/// `None` when persistence is not needed (e.g., nested script execution, tests).

crates/vite_task/src/session/reporter/summary.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -459,12 +459,12 @@ impl TaskResult {
459459
}
460460

461461
// ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
462-
// Full summary rendering (--verbose and --last-details)
462+
// Full summary rendering (--details and --last-details)
463463
// ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
464464

465465
/// Render the full detailed execution summary.
466466
///
467-
/// Used by both `--verbose` (live) and `--last-details` (from file).
467+
/// Used by both `--details` (live) and `--last-details` (from file).
468468
#[expect(
469469
clippy::too_many_lines,
470470
reason = "summary formatting is inherently verbose with many write calls"
@@ -647,7 +647,7 @@ pub fn format_full_summary(summary: &LastRunSummary) -> Vec<u8> {
647647
/// - Single task + not cache hit → empty (no summary at all)
648648
/// - Single task + cache hit → thin line + "[vp run] cache hit, {duration} saved."
649649
/// - Multi-task → thin line + "[vp run] {hits}/{total} cache hit ({rate}%), {duration} saved."
650-
/// with optional failure count and `--verbose` hint.
650+
/// with optional failure count and `--details` hint.
651651
pub fn format_compact_summary(summary: &LastRunSummary) -> Vec<u8> {
652652
let stats = SummaryStats::compute(&summary.tasks);
653653

@@ -713,7 +713,7 @@ pub fn format_compact_summary(summary: &LastRunSummary) -> Vec<u8> {
713713
let _ = write!(
714714
buf,
715715
". {}",
716-
"(Run `vp run --verbose` for full details)".style(Style::new().bright_black()),
716+
"(Run `vp run --details` for full details)".style(Style::new().bright_black()),
717717
);
718718
let _ = writeln!(buf);
719719
}

crates/vite_task_bin/tests/e2e_snapshots/fixtures/associate-existing-cache/snapshots.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
[[e2e]]
44
name = "associate existing cache"
55
steps = [
6-
"vp run --verbose script1 # cache miss",
7-
"vp run --verbose script2 # cache hit, same command as script1",
6+
"vp run --details script1 # cache miss",
7+
"vp run --details script2 # cache hit, same command as script1",
88
"json-edit package.json '_.scripts.script2 = \"print world\"' # change script2",
9-
"vp run --verbose script2 # cache miss",
9+
"vp run --details script2 # cache miss",
1010
]

crates/vite_task_bin/tests/e2e_snapshots/fixtures/associate-existing-cache/snapshots/associate existing cache.snap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
source: crates/vite_task_bin/tests/e2e_snapshots/main.rs
33
expression: e2e_outputs
44
---
5-
> vp run --verbose script1 # cache miss
5+
> vp run --details script1 # cache miss
66
$ print hello
77
hello
88

@@ -19,7 +19,7 @@ Task Details:
1919
[1] script1: $ print hello
2020
Cache miss: no previous cache entry found
2121
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
22-
> vp run --verbose script2 # cache hit, same command as script1
22+
> vp run --details script2 # cache hit, same command as script1
2323
$ print hellocache hit, replaying
2424
hello
2525

@@ -38,7 +38,7 @@ Task Details:
3838
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
3939
> json-edit package.json '_.scripts.script2 = "print world"' # change script2
4040

41-
> vp run --verbose script2 # cache miss
41+
> vp run --details script2 # cache miss
4242
$ print world ✗ cache miss: args changed, executing
4343
world
4444

crates/vite_task_bin/tests/e2e_snapshots/fixtures/builtin-different-cwd/snapshots.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
[[e2e]]
44
name = "builtin different cwd"
55
steps = [
6-
"cd folder1 && vp run --verbose lint # cache miss in folder1",
7-
"cd folder2 && vp run --verbose lint # cache miss in folder2",
6+
"cd folder1 && vp run --details lint # cache miss in folder1",
7+
"cd folder2 && vp run --details lint # cache miss in folder2",
88
"echo 'console.log(1);' > folder2/a.js # modify folder2",
9-
"cd folder1 && vp run --verbose lint # cache hit",
10-
"cd folder2 && vp run --verbose lint # cache miss",
9+
"cd folder1 && vp run --details lint # cache hit",
10+
"cd folder2 && vp run --details lint # cache miss",
1111
]

crates/vite_task_bin/tests/e2e_snapshots/fixtures/builtin-different-cwd/snapshots/builtin different cwd.snap

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
source: crates/vite_task_bin/tests/e2e_snapshots/main.rs
33
expression: e2e_outputs
44
---
5-
> cd folder1 && vp run --verbose lint # cache miss in folder1
5+
> cd folder1 && vp run --details lint # cache miss in folder1
66
$ vp lint
77

88
! eslint-plugin-unicorn(no-empty-file): Empty files are not allowed.
@@ -35,7 +35,7 @@ Task Details:
3535
[1] lint: $ vp lint ✓
3636
→ Cache miss: no previous cache entry found
3737
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
38-
> cd folder2 && vp run --verbose lint # cache miss in folder2
38+
> cd folder2 && vp run --details lint # cache miss in folder2
3939
$ vp lint ✓ cache hit, replaying
4040

4141
! eslint-plugin-unicorn(no-empty-file): Empty files are not allowed.
@@ -70,7 +70,7 @@ Task Details:
7070
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
7171
> echo 'console.log(1);' > folder2/a.js # modify folder2
7272

73-
> cd folder1 && vp run --verbose lint # cache hit
73+
> cd folder1 && vp run --details lint # cache hit
7474
$ vp lint ✗ cache miss: content of input 'folder2/a.js' changed, executing
7575

7676
! eslint-plugin-unicorn(no-empty-file): Empty files are not allowed.
@@ -96,7 +96,7 @@ Task Details:
9696
[1] lint: $ vp lint ✓
9797
→ Cache miss: content of input 'folder2/a.js' changed
9898
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
99-
> cd folder2 && vp run --verbose lint # cache miss
99+
> cd folder2 && vp run --details lint # cache miss
100100
$ vp lint ✓ cache hit, replaying
101101

102102
! eslint-plugin-unicorn(no-empty-file): Empty files are not allowed.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[[e2e]]
22
name = "builtin command with non-zero exit does not show cache not updated"
33
steps = [
4-
"vp run --verbose lint -- -D no-debugger",
5-
"vp run --verbose lint -- -D no-debugger",
4+
"vp run --details lint -- -D no-debugger",
5+
"vp run --details lint -- -D no-debugger",
66
]

crates/vite_task_bin/tests/e2e_snapshots/fixtures/builtin-non-zero-exit/snapshots/builtin command with non-zero exit does not show cache not updated.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
source: crates/vite_task_bin/tests/e2e_snapshots/main.rs
33
expression: e2e_outputs
44
---
5-
[1]> vp run --verbose lint -- -D no-debugger
5+
[1]> vp run --details lint -- -D no-debugger
66
$ vp lint -D no-debugger
77

88
x eslint(no-debugger): `debugger` statement is not allowed
@@ -28,7 +28,7 @@ Task Details:
2828
[1] builtin-non-zero-exit-test#lint: $ vp lint -D no-debugger ✗ (exit code: 1)
2929
→ Cache miss: no previous cache entry found
3030
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
31-
[1]> vp run --verbose lint -- -D no-debugger
31+
[1]> vp run --details lint -- -D no-debugger
3232
$ vp lint -D no-debugger
3333
3434
x eslint(no-debugger): `debugger` statement is not allowed

0 commit comments

Comments
 (0)