fix(plan): add shell arguments for shell fallback execution

Author: branchseer

crates/vite_task_plan/src/plan.rs

@@ -239,6 +239,9 @@ async fn plan_task_as_execution_node(
             }
         });
 
+        static SHELL_ARGS: &[&str] =
+            if cfg!(target_os = "windows") { &["/d", "/s", "/c"] } else { &["-c"] };
+
         let mut script = Str::from(command_str);
         for arg in context.extra_args().iter() {
             script.push(' ');
@@ -266,7 +269,7 @@ async fn plan_task_as_execution_node(
             &task_node.resolved_config.resolved_options,
             context.envs(),
             Arc::clone(&*SHELL_PROGRAM_PATH),
-            Arc::new([script]),
+            Arc::from_iter(SHELL_ARGS.iter().map(|s| Str::from(*s)).chain(std::iter::once(script))),
         )
         .with_plan_context(&context)?;
         items.push(ExecutionItem {

crates/vite_task_plan/tests/plan_snapshots/fixtures/shell-fallback/package.json

@@ -0,0 +1,5 @@
+{
+  "scripts": {
+    "pipe-test": "echo hello | node -e \"process.stdin.pipe(process.stdout)\""
+  }
+}

crates/vite_task_plan/tests/plan_snapshots/fixtures/shell-fallback/snapshots.toml

@@ -0,0 +1,3 @@
+[[plan]]
+name = "shell fallback for pipe command"
+args = ["run", "pipe-test"]

crates/vite_task_plan/tests/plan_snapshots/fixtures/shell-fallback/snapshots/query - shell fallback for pipe command.snap

@@ -0,0 +1,89 @@
+---
+source: crates/vite_task_plan/tests/plan_snapshots/main.rs
+assertion_line: 139
+expression: "&plan_json"
+input_file: crates/vite_task_plan/tests/plan_snapshots/fixtures/shell-fallback
+---
+{
+  "root_node": {
+    "Expanded": [
+      {
+        "key": [
+          "<workspace>/",
+          "pipe-test"
+        ],
+        "node": {
+          "task_display": {
+            "package_name": "",
+            "task_name": "pipe-test",
+            "package_path": "<workspace>/"
+          },
+          "items": [
+            {
+              "execution_item_display": {
+                "task_display": {
+                  "package_name": "",
+                  "task_name": "pipe-test",
+                  "package_path": "<workspace>/"
+                },
+                "command": "echo hello | node -e \"process.stdin.pipe(process.stdout)\"",
+                "and_item_index": null,
+                "cwd": "<workspace>/"
+              },
+              "kind": {
+                "Leaf": {
+                  "Spawn": {
+                    "cache_metadata": {
+                      "spawn_fingerprint": {
+                        "cwd": "",
+                        "program_fingerprint": {
+                          "OutsideWorkspace": {
+                            "program_name": "sh"
+                          }
+                        },
+                        "args": [
+                          "-c",
+                          "echo hello | node -e \"process.stdin.pipe(process.stdout)\""
+                        ],
+                        "env_fingerprints": {
+                          "fingerprinted_envs": {},
+                          "pass_through_env_config": [
+                            "<default pass-through envs>"
+                          ]
+                        },
+                        "fingerprint_ignores": null
+                      },
+                      "execution_cache_key": {
+                        "kind": {
+                          "UserTask": {
+                            "task_name": "pipe-test",
+                            "and_item_index": 0,
+                            "extra_args": []
+                          }
+                        },
+                        "origin_path": ""
+                      }
+                    },
+                    "spawn_command": {
+                      "program_path": "<shell>",
+                      "args": [
+                        "<shell-arg>",
+                        "echo hello | node -e \"process.stdin.pipe(process.stdout)\""
+                      ],
+                      "all_envs": {
+                        "NO_COLOR": "1",
+                        "PATH": "<workspace>/node_modules/.bin:<tools>/node_modules/.bin"
+                      },
+                      "cwd": "<workspace>/"
+                    }
+                  }
+                }
+              }
+            }
+          ]
+        },
+        "neighbors": []
+      }
+    ]
+  }
+}

crates/vite_task_plan/tests/plan_snapshots/fixtures/shell-fallback/snapshots/task graph.snap

@@ -0,0 +1,36 @@
+---
+source: crates/vite_task_plan/tests/plan_snapshots/main.rs
+assertion_line: 106
+expression: task_graph_json
+input_file: crates/vite_task_plan/tests/plan_snapshots/fixtures/shell-fallback
+---
+[
+  {
+    "key": [
+      "<workspace>/",
+      "pipe-test"
+    ],
+    "node": {
+      "task_display": {
+        "package_name": "",
+        "task_name": "pipe-test",
+        "package_path": "<workspace>/"
+      },
+      "resolved_config": {
+        "command": "echo hello | node -e \"process.stdin.pipe(process.stdout)\"",
+        "resolved_options": {
+          "cwd": "<workspace>/",
+          "cache_config": {
+            "env_config": {
+              "fingerprinted_envs": [],
+              "pass_through_envs": [
+                "<default pass-through envs>"
+              ]
+            }
+          }
+        }
+      }
+    },
+    "neighbors": []
+  }
+]

crates/vite_task_plan/tests/plan_snapshots/redact.rs

@@ -108,6 +108,47 @@ pub fn redact_snapshot(value: &impl Serialize, workspace_root: &str) -> serde_js
         }
     });
 
+    // Normalize shell program paths and arguments for cross-platform consistency
+    visit_json(&mut json_value, &mut |v| {
+        let serde_json::Value::Object(map) = v else {
+            return;
+        };
+
+        // Check if program_path is a shell
+        let is_shell =
+            if let Some(serde_json::Value::String(program_path)) = map.get("program_path") {
+                let lower = program_path.to_lowercase();
+                if cfg!(windows) {
+                    lower.ends_with("cmd") || lower.ends_with("cmd.exe")
+                } else {
+                    program_path == "/bin/sh"
+                }
+            } else {
+                false
+            };
+
+        if !is_shell {
+            return;
+        }
+
+        // Redact shell program path
+        if let Some(serde_json::Value::String(program_path)) = map.get_mut("program_path") {
+            *program_path = "<shell>".to_string();
+        }
+
+        // Redact shell arguments
+        if let Some(serde_json::Value::Array(args)) = map.get_mut("args") {
+            let shell_args: &[&str] = if cfg!(windows) { &["/d", "/s", "/c"] } else { &["-c"] };
+            for arg in args.iter_mut() {
+                if let serde_json::Value::String(s) = arg {
+                    if shell_args.contains(&s.as_str()) {
+                        *s = "<shell-arg>".to_string();
+                    }
+                }
+            }
+        }
+    });
+
     visit_json(&mut json_value, &mut |v| {
         let serde_json::Value::Array(array) = v else {
             return;