refactor: change post_execution and execute return type to Result<(), ExitCode>

Use Result type for clearer success/failure semantics:
- Ok(()) for success (exit code 0)
- Err(ExitCode) for failure with specific exit code

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: branchseer

crates/vite_task/src/session/execute/mod.rs

@@ -330,8 +330,12 @@ impl ExecutionContext<'_> {
 impl<'a, CustomSubcommand> Session<'a, CustomSubcommand> {
     /// Execute an execution plan, reporting events to the provided reporter.
     ///
-    /// Returns the ExitCode from the reporter's post_execution method.
-    pub async fn execute(&self, plan: ExecutionPlan, mut reporter: Box<dyn Reporter>) -> ExitCode {
+    /// Returns Ok(()) on success, or Err(ExitCode) on failure.
+    pub async fn execute(
+        &self,
+        plan: ExecutionPlan,
+        mut reporter: Box<dyn Reporter>,
+    ) -> Result<(), ExitCode> {
         let mut execution_context = ExecutionContext {
             event_handler: &mut *reporter,
             current_execution_id: ExecutionId::zero(),

crates/vite_task/src/session/reporter.rs

@@ -35,8 +35,8 @@ pub trait Reporter {
     fn handle_event(&mut self, event: ExecutionEvent);
 
     /// Called after execution completes (whether successful or not)
-    /// Returns an ExitCode that is a suggestion for process exit
-    fn post_execution(self: Box<Self>) -> ExitCode;
+    /// Returns Ok(()) on success, or Err(ExitCode) on failure
+    fn post_execution(self: Box<Self>) -> Result<(), ExitCode>;
 }
 
 const COMMAND_STYLE: Style = Style::new().cyan();
@@ -487,7 +487,7 @@ impl<W: Write> Reporter for LabeledReporter<W> {
         }
     }
 
-    fn post_execution(mut self: Box<Self>) -> ExitCode {
+    fn post_execution(mut self: Box<Self>) -> Result<(), ExitCode> {
         // Check if execution was aborted due to error
         if let Some(error_msg) = &self.first_error {
             // Print separator
@@ -514,7 +514,7 @@ impl<W: Write> Reporter for LabeledReporter<W> {
                     .style(Style::new().bright_black())
             );
 
-            return ExitCode::FAILURE;
+            return Err(ExitCode::FAILURE);
         }
 
         // No errors - print summary if not hidden
@@ -528,9 +528,9 @@ impl<W: Write> Reporter for LabeledReporter<W> {
         }
 
         // Determine exit code based on failed tasks:
-        // 1. All tasks succeed → return 0
-        // 2. Exactly one task failed → return that task's exit code
-        // 3. More than one task failed → return 1
+        // 1. All tasks succeed → return Ok(())
+        // 2. Exactly one task failed → return Err with that task's exit code
+        // 3. More than one task failed → return Err(1)
         let failed_exit_codes: Vec<i32> = self
             .executions
             .iter()
@@ -539,13 +539,13 @@ impl<W: Write> Reporter for LabeledReporter<W> {
             .collect();
 
         match failed_exit_codes.len() {
-            0 => ExitCode::SUCCESS,
+            0 => Ok(()),
             1 => {
                 // Return the single failed task's exit code (clamped to u8 range)
                 let code = failed_exit_codes[0];
-                ExitCode::from(code.clamp(1, 255) as u8)
+                Err(ExitCode::from(code.clamp(1, 255) as u8))
             }
-            _ => ExitCode::FAILURE,
+            _ => Err(ExitCode::FAILURE),
         }
     }
 }

crates/vite_task_bin/src/main.rs

@@ -40,7 +40,5 @@ async fn run() -> anyhow::Result<ExitCode> {
 
     // Create reporter and execute
     let reporter = LabeledReporter::new(std::io::stdout(), session.workspace_path());
-    let exit_code = session.execute(plan, Box::new(reporter)).await;
-
-    Ok(exit_code)
+    Ok(session.execute(plan, Box::new(reporter)).await.err().unwrap_or(ExitCode::SUCCESS))
 }