update

Author: branchseer

crates/vite_task_graph/tests/fixtures/transitive-dependency-workspace/cli-queries.toml

@@ -10,12 +10,17 @@ args = ["build"]
 
 [[query]]
 name = "explicit package name under different package"
-cwd = "packages/b"
-args = ["@test/a#build"]
+cwd = "packages/a"
+args = ["@test/c#build"]
 
 [[query]]
 name = "explicit package name under non-package cwd"
 cwd = ""
+args = ["@test/c#build"]
+
+[[query]]
+name = "ambiguous task name"
+cwd = ""
 args = ["@test/a#build"]
 
 [[query]]
@@ -33,6 +38,11 @@ name = "transitive in package without the task"
 cwd = "packages/a"
 args = ["--transitive", "lint"]
 
+[[query]]
+name = "transitive non existent task"
+cwd = "packages/a"
+args = ["--transitive", "non-existent-task"]
+
 [[query]]
 name = "recursive"
 cwd = ""

crates/vite_task_graph/tests/fixtures/transitive-dependency-workspace/packages/another-a/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "@test/a",
+  "version": "1.0.0",
+  "scripts": {
+    "build": "echo Building another A"
+  }
+}

crates/vite_task_graph/tests/fixtures/transitive-dependency-workspace/packages/another-c/package.json

@@ -178,7 +178,9 @@ fn run_case(runtime: &Runtime, tmpdir: &AbsolutePath, case_path: &Path) {
         )
         .await
         .expect(&format!("Failed to load task graph for case {case_name}"));
+
         let task_graph_snapshot = snapshot_task_graph(&indexed_task_graph, &case_stage_path);
+        insta::assert_json_snapshot!("task graph", task_graph_snapshot);
 
         for cli_query in cli_queries_file.queries {
             let snapshot_name = format!("query - {}", cli_query.name);
@@ -205,18 +207,15 @@ fn run_case(runtime: &Runtime, tmpdir: &AbsolutePath, case_path: &Path) {
                 Ok(ok) => ok,
                 Err(mut err) => {
                     stablize_specifier_lookup_error(&mut err, &case_stage_path);
-                    insta::assert_snapshot!(snapshot_name, err);
+                    insta::assert_debug_snapshot!(snapshot_name, err);
                     continue;
                 }
             };
 
             let execution_graph_snapshot =
                 snapshot_execution_graph(&execution_graph, &indexed_task_graph, &case_stage_path);
-
             insta::assert_json_snapshot!(snapshot_name, execution_graph_snapshot);
         }
-
-        insta::assert_json_snapshot!("task graph", task_graph_snapshot);
     });
 }
 

crates/vite_task_graph/tests/snapshots.rs

@@ -0,0 +1,16 @@
+---
+source: crates/vite_task_graph/tests/snapshots.rs
+expression: err
+input_file: crates/vite_task_graph/tests/fixtures/transitive-dependency-workspace
+---
+AmbiguousPackageName {
+    package_name: "@test/a",
+    package_paths: [
+        AbsolutePath(
+            "/workspace/packages/a",
+        ),
+        AbsolutePath(
+            "/workspace/packages/another-a",
+        ),
+    ],
+}

crates/vite_task_graph/tests/snapshots/snapshots__query - ambiguous task name@transitive-dependency-workspace.snap

@@ -6,21 +6,9 @@ input_file: crates/vite_task_graph/tests/fixtures/transitive-dependency-workspac
 [
   {
     "task": {
-      "package_dir": "packages/a",
+      "package_dir": "packages/c",
       "task_name": "build"
     },
-    "deps": [
-      {
-        "package_dir": "packages/a",
-        "task_name": "test"
-      }
-    ]
-  },
-  {
-    "task": {
-      "package_dir": "packages/a",
-      "task_name": "test"
-    },
     "deps": []
   }
 ]

crates/vite_task_graph/tests/snapshots/snapshots__query - explicit package name under different package@transitive-dependency-workspace.snap

@@ -6,21 +6,9 @@ input_file: crates/vite_task_graph/tests/fixtures/transitive-dependency-workspac
 [
   {
     "task": {
-      "package_dir": "packages/a",
+      "package_dir": "packages/c",
       "task_name": "build"
     },
-    "deps": [
-      {
-        "package_dir": "packages/a",
-        "task_name": "test"
-      }
-    ]
-  },
-  {
-    "task": {
-      "package_dir": "packages/a",
-      "task_name": "test"
-    },
     "deps": []
   }
 ]

crates/vite_task_graph/tests/snapshots/snapshots__query - explicit package name under non-package cwd@transitive-dependency-workspace.snap

@@ -31,6 +31,13 @@ input_file: crates/vite_task_graph/tests/fixtures/transitive-dependency-workspac
     },
     "deps": []
   },
+  {
+    "task": {
+      "package_dir": "packages/another-a",
+      "task_name": "build"
+    },
+    "deps": []
+  },
   {
     "task": {
       "package_dir": "packages/b2",

crates/vite_task_graph/tests/snapshots/snapshots__query - recursive@transitive-dependency-workspace.snap

@@ -0,0 +1,10 @@
+---
+source: crates/vite_task_graph/tests/snapshots.rs
+expression: err
+input_file: crates/vite_task_graph/tests/fixtures/transitive-dependency-workspace
+---
+TaskNameNotFound {
+    package_name: "@test/a",
+    task_name: "non-existent-task",
+    package_index: NodeIndex(PackageIx(0)),
+}

crates/vite_task_graph/tests/snapshots/snapshots__query - transitive non existent task@transitive-dependency-workspace.snap

@@ -44,6 +44,15 @@ input_file: crates/vite_task_graph/tests/fixtures/transitive-dependency-workspac
     "cwd": "packages/a",
     "depends_on": []
   },
+  {
+    "id": {
+      "package_dir": "packages/another-a",
+      "task_name": "build"
+    },
+    "command": "echo Building another A",
+    "cwd": "packages/another-a",
+    "depends_on": []
+  },
   {
     "id": {
       "package_dir": "packages/b1",