Skip to content

Commit ebc4b1b

Browse files
branchseerclaude
andcommitted
chore: rename vite_pty to pty_terminal
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent bd0685e commit ebc4b1b

15 files changed

Lines changed: 576 additions & 420 deletions

File tree

.clippy.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ disallowed-methods = [
88
{ path = "str::replace", reason = "To avoid memory allocation, use `cow_utils::CowUtils::cow_replace` instead." },
99
{ path = "str::replacen", reason = "To avoid memory allocation, use `cow_utils::CowUtils::cow_replacen` instead." },
1010
{ path = "std::env::current_dir", reason = "To get an `AbsolutePathBuf`, Use `vite_path::current_dir` instead." },
11+
{ path = "std::thread::sleep", reason = "Use proper synchronization (channels, condvars, etc.) instead of sleeping. Sleep is only acceptable for intentional user-facing delays (e.g. animations, debouncing)." },
12+
{ path = "tokio::time::sleep", reason = "Use proper synchronization (channels, signals, etc.) instead of sleeping. Sleep is only acceptable for intentional user-facing delays (e.g. animations, debouncing)." },
1113
]
1214

1315
disallowed-types = [

.non-vite.clippy.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Clippy configuration for non-vite crates (fspy_*, subprocess_test, vite_pty, etc.)
1+
# Clippy configuration for non-vite crates (fspy_*, subprocess_test, pty_terminal, etc.)
22
# that don't depend on vite_str/vite_path.
33
#
44
# This is a subset of the root .clippy.toml, with rules recommending vite_str/vite_path
@@ -16,6 +16,8 @@ disallowed-methods = [
1616
{ path = "str::to_uppercase", reason = "To avoid memory allocation, use `cow_utils::CowUtils::cow_to_uppercase` instead." },
1717
{ path = "str::replace", reason = "To avoid memory allocation, use `cow_utils::CowUtils::cow_replace` instead." },
1818
{ path = "str::replacen", reason = "To avoid memory allocation, use `cow_utils::CowUtils::cow_replacen` instead." },
19+
{ path = "std::thread::sleep", reason = "Use proper synchronization (channels, condvars, etc.) instead of sleeping. Sleep is only acceptable for intentional user-facing delays (e.g. animations, debouncing)." },
20+
{ path = "tokio::time::sleep", reason = "Use proper synchronization (channels, signals, etc.) instead of sleeping. Sleep is only acceptable for intentional user-facing delays (e.g. animations, debouncing)." },
1921
]
2022

2123
disallowed-types = [

CLAUDE.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ Test fixtures and snapshots:
5353
cargo xtest --builder cargo-xwin --target aarch64-pc-windows-msvc -p <package> --test <test>
5454

5555
# Examples:
56-
cargo xtest --builder cargo-xwin --target aarch64-pc-windows-msvc -p vite_pty --test terminal
57-
cargo xtest --builder cargo-xwin --target aarch64-pc-windows-msvc -p vite_pty --test terminal -- resize_terminal
56+
cargo xtest --builder cargo-xwin --target aarch64-pc-windows-msvc -p pty_terminal --test terminal
57+
cargo xtest --builder cargo-xwin --target aarch64-pc-windows-msvc -p pty_terminal --test terminal -- resize_terminal
5858
```
5959

6060
3. **Cross-Platform Test Design Patterns**:
@@ -64,7 +64,7 @@ Test fixtures and snapshots:
6464
- **Unix**: SIGWINCH signals, ioctl, /dev/null, etc.
6565
- **Windows**: ConPTY, GetConsoleScreenBufferInfo, NUL, etc.
6666

67-
4. **Example**: The `vite_pty::resize_terminal` test demonstrates proper cross-platform testing:
67+
4. **Example**: The `pty_terminal::resize_terminal` test demonstrates proper cross-platform testing:
6868
- Unix: Installs SIGWINCH handler to verify signal delivery
6969
- Windows: Acknowledges synchronous ConPTY resize behavior
7070
- Both: Query terminal size using cross-platform `terminal_size` crate

0 commit comments

Comments
 (0)