refactor: store original filter strings for unmatched_selectors

`unmatched_selectors` was `Vec<usize>` (indices into the internal filter
list), but those indices don't map back to CLI args after whitespace
splitting and synthetic filter injection. Change to `Vec<Str>` by
storing the original `--filter` token as `source: Option<Str>` in each
`PackageFilter`. Synthetic filters (implicit cwd, `-w`) get `None` so
they are never reported as unmatched.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: branchseer

crates/vite_task_graph/src/query/mod.rs

@@ -53,12 +53,11 @@ pub struct TaskQueryResult {
     /// decide whether to show task-not-found UI.
     pub execution_graph: TaskExecutionGraph,
 
-    /// Indices into the original `PackageQuery::Filters` slice for selectors that
-    /// matched no packages. The caller maps each index back to the original
-    /// `--filter` string for typo warnings.
+    /// Original `--filter` strings for inclusion selectors that matched no packages.
     ///
+    /// Omits synthetic filters (implicit cwd, `-w`) since the user didn't type them.
     /// Always empty when `PackageQuery::All` was used.
-    pub unmatched_selectors: Vec<usize>,
+    pub unmatched_selectors: Vec<Str>,
 }
 
 impl IndexedTaskGraph {

crates/vite_workspace/src/package_filter.rs

@@ -155,6 +155,10 @@ pub(crate) struct PackageFilter {
     /// Optional graph expansion from the initial match.
     /// `None` = exact match only (no traversal).
     pub(crate) traversal: Option<GraphTraversal>,
+
+    /// Original `--filter` token that produced this filter.
+    /// `None` for synthetic filters (implicit cwd, package name, `-w`).
+    pub(crate) source: Option<Str>,
 }
 
 // ────────────────────────────────────────────────────────────────────────────
@@ -280,6 +284,7 @@ impl PackageQueryArgs {
                     exclude: false,
                     selector: PackageSelector::WorkspaceRoot,
                     traversal: None,
+                    source: None,
                 });
             }
             return Ok(PackageQuery::filters(parsed));
@@ -304,6 +309,7 @@ impl PackageQueryArgs {
                 exclude: false,
                 selector: PackageSelector::WorkspaceRoot,
                 traversal,
+                source: None,
             })));
         }
 
@@ -320,7 +326,12 @@ impl PackageQueryArgs {
         } else {
             None
         };
-        Ok(PackageQuery::filters(Vec1::new(PackageFilter { exclude: false, selector, traversal })))
+        Ok(PackageQuery::filters(Vec1::new(PackageFilter {
+            exclude: false,
+            selector,
+            traversal,
+            source: None,
+        })))
     }
 }
 
@@ -391,7 +402,7 @@ pub(crate) fn parse_filter(
     // Ref: https://github.com/pnpm/pnpm/issues/1651
     let traversal = if supports_traversal { traversal } else { None };
 
-    Ok(PackageFilter { exclude, selector, traversal })
+    Ok(PackageFilter { exclude, selector, traversal, source: Some(Str::from(input)) })
 }
 
 /// Parse the core selector string (after stripping `!` and `...` markers).
@@ -1113,4 +1124,72 @@ mod tests {
             Err(PackageQueryError::PackageNameWithWorkspaceRoot { .. })
         ));
     }
+
+    // ── source field ───────────────────────────────────────────────────────
+
+    #[test]
+    fn parse_filter_sets_source() {
+        let cwd = abs("/workspace");
+        let f = parse_filter("@test/app...", cwd).unwrap();
+        assert_eq!(f.source.as_deref(), Some("@test/app..."));
+    }
+
+    #[test]
+    fn filter_source_preserved_after_whitespace_split() {
+        let cwd: Arc<AbsolutePath> = Arc::from(abs("/workspace"));
+        let args = PackageQueryArgs {
+            recursive: false,
+            transitive: false,
+            workspace_root: false,
+            filter: vec![Str::from("a b")],
+        };
+        let query = args.into_package_query(None, &cwd).unwrap();
+        match &query.0 {
+            crate::package_graph::PackageQueryKind::Filters(filters) => {
+                assert_eq!(filters.len(), 2);
+                assert_eq!(filters[0].source.as_deref(), Some("a"));
+                assert_eq!(filters[1].source.as_deref(), Some("b"));
+            }
+            other => panic!("expected Filters, got {other:?}"),
+        }
+    }
+
+    #[test]
+    fn synthetic_workspace_root_filter_has_no_source() {
+        let cwd: Arc<AbsolutePath> = Arc::from(abs("/workspace"));
+        let args = PackageQueryArgs {
+            recursive: false,
+            transitive: false,
+            workspace_root: true,
+            filter: vec![Str::from("foo")],
+        };
+        let query = args.into_package_query(None, &cwd).unwrap();
+        match &query.0 {
+            crate::package_graph::PackageQueryKind::Filters(filters) => {
+                assert_eq!(filters.len(), 2);
+                assert_eq!(filters[0].source.as_deref(), Some("foo"));
+                assert!(filters[1].source.is_none());
+            }
+            other => panic!("expected Filters, got {other:?}"),
+        }
+    }
+
+    #[test]
+    fn implicit_cwd_filter_has_no_source() {
+        let cwd: Arc<AbsolutePath> = Arc::from(abs("/workspace/packages/app"));
+        let args = PackageQueryArgs {
+            recursive: false,
+            transitive: false,
+            workspace_root: false,
+            filter: Vec::new(),
+        };
+        let query = args.into_package_query(None, &cwd).unwrap();
+        match &query.0 {
+            crate::package_graph::PackageQueryKind::Filters(filters) => {
+                assert_eq!(filters.len(), 1);
+                assert!(filters[0].source.is_none());
+            }
+            other => panic!("expected Filters, got {other:?}"),
+        }
+    }
 }

crates/vite_workspace/src/package_graph.rs

@@ -86,11 +86,11 @@ pub struct FilterResolution {
     /// stage (construction time), keeping all downstream code edge-type-agnostic.
     pub package_subgraph: DiGraphMap<PackageNodeIndex, ()>,
 
-    /// Indices into the input `filters` slice for selectors that matched no packages.
+    /// Original `--filter` strings for inclusion selectors that matched no packages.
     ///
-    /// The caller maps each index back to the original `--filter` string to emit
-    /// typo warnings. Empty when `PackageQuery::All` is used.
-    pub unmatched_selectors: Vec<usize>,
+    /// Omits synthetic filters (implicit cwd, `-w`) since the user didn't type them.
+    /// Empty when `PackageQuery::All` is used.
+    pub unmatched_selectors: Vec<Str>,
 }
 
 // ────────────────────────────────────────────────────────────────────────────
@@ -213,8 +213,7 @@ impl IndexedPackageGraph {
     fn resolve_filters(&self, filters: &[PackageFilter]) -> FilterResolution {
         let mut unmatched_selectors = Vec::new();
 
-        let (inclusions, exclusions): (Vec<_>, Vec<_>) =
-            filters.iter().enumerate().partition(|(_, f)| !f.exclude);
+        let (inclusions, exclusions): (Vec<_>, Vec<_>) = filters.iter().partition(|f| !f.exclude);
 
         // Start from all packages when there are no inclusions (exclude-only mode).
         let mut selected: FxHashSet<PackageNodeIndex> = if inclusions.is_empty() {
@@ -224,17 +223,19 @@ impl IndexedPackageGraph {
         };
 
         // Apply inclusions: union each filter's resolved set into `selected`.
-        for (filter_idx, filter) in &inclusions {
+        for filter in &inclusions {
             let matched = self.resolve_selector_entries(&filter.selector);
-            if matched.is_empty() {
-                unmatched_selectors.push(*filter_idx);
+            if matched.is_empty()
+                && let Some(source) = &filter.source
+            {
+                unmatched_selectors.push(source.clone());
             }
             let expanded = self.expand_traversal(matched, filter.traversal.as_ref());
             selected.extend(expanded);
         }
 
         // Apply exclusions: subtract each filter's resolved set from `selected`.
-        for (_, filter) in &exclusions {
+        for filter in &exclusions {
             let matched = self.resolve_selector_entries(&filter.selector);
             let to_remove = self.expand_traversal(matched, filter.traversal.as_ref());
             for pkg in to_remove {