fix: suggest stdio mode by leaf graph path

Author: branchseer

crates/vite_task/src/session/reporter/labeled.rs

@@ -1,7 +1,8 @@
 # Tests stdin inheritance behavior for spawned tasks.
 #
 # Stdin is inherited from the parent process only when BOTH conditions are met:
-# 1. The reporter suggests inherited stdin (single spawn leaf in the graph, or synthetic execution)
+# 1. The reporter suggests inherited stdin (the leaf is in a single-node graph chain,
+#    or the execution uses PlainReporter for synthetic execution)
 # 2. Caching is disabled for the task (cache_metadata is None)
 #
 # Otherwise, stdin is set to /dev/null.

crates/vite_task_bin/tests/e2e_snapshots/fixtures/stdin-inheritance/snapshots.toml

@@ -0,0 +1,4 @@
+{
+  "name": "stdio-graph-criteria-test",
+  "private": true
+}

crates/vite_task_bin/tests/e2e_snapshots/fixtures/stdio-graph-criteria/package.json

@@ -0,0 +1,3 @@
+{
+  "name": "other"
+}

crates/vite_task_bin/tests/e2e_snapshots/fixtures/stdio-graph-criteria/packages/other/package.json

@@ -0,0 +1,16 @@
+{
+  "tasks": {
+    "check-tty": {
+      "command": "check-tty",
+      "cache": false
+    },
+    "bar": {
+      "command": "check-tty",
+      "cache": false
+    },
+    "foo-nested": {
+      "command": "vp run bar",
+      "cache": false
+    }
+  }
+}

crates/vite_task_bin/tests/e2e_snapshots/fixtures/stdio-graph-criteria/packages/other/vite-task.json

@@ -0,0 +1,2 @@
+packages:
+  - packages/*

crates/vite_task_bin/tests/e2e_snapshots/fixtures/stdio-graph-criteria/pnpm-workspace.yaml

@@ -0,0 +1,19 @@
+# Tests stdio suggestion criteria based on graph shape along each leaf path.
+#
+# Rules under test:
+# - Suggest piped when the leaf's containing graph has more than one node, or
+#   any ancestor graph on its path has more than one node.
+# - Suggest inherited only when every graph on the path (root + nested Expanded
+#   graphs) has exactly one node.
+
+[[e2e]]
+name = "single-node chains inherit even with multi-node sibling graph"
+steps = [
+  "vp run foo",
+]
+
+[[e2e]]
+name = "multi-node ancestor forces piped for nested single-node graph"
+steps = [
+  "vp run -r foo-nested",
+]

crates/vite_task_bin/tests/e2e_snapshots/fixtures/stdio-graph-criteria/snapshots.toml

@@ -0,0 +1,31 @@
+---
+source: crates/vite_task_bin/tests/e2e_snapshots/main.rs
+expression: e2e_outputs
+---
+> vp run -r foo-nested
+~/packages/other$ check-tty ⊘ cache disabled: no cache config
+stdin:not-tty
+stdout:not-tty
+stderr:not-tty
+
+$ check-tty ⊘ cache disabled: no cache config
+stdin:not-tty
+stdout:not-tty
+stderr:not-tty
+
+
+━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+    Vite+ Task Runner • Execution Summary
+━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+Statistics:   2 tasks • 0 cache hits • 0 cache misses • 2 cache disabled
+Performance:  0% cache hit rate
+
+Task Details:
+────────────────────────────────────────────────
+  [1] other#bar: ~/packages/other$ check-tty ✓
+      → Cache disabled in task configuration
+  ·······················································
+  [2] stdio-graph-criteria-test#bar: $ check-tty ✓
+      → Cache disabled in task configuration
+━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

crates/vite_task_bin/tests/e2e_snapshots/fixtures/stdio-graph-criteria/snapshots/multi-node ancestor forces piped for nested single-node graph.snap

@@ -0,0 +1,47 @@
+---
+source: crates/vite_task_bin/tests/e2e_snapshots/main.rs
+expression: e2e_outputs
+---
+> vp run foo
+$ check-tty ⊘ cache disabled: no cache config
+stdin:tty
+stdout:tty
+stderr:tty
+
+$ check-tty ⊘ cache disabled: no cache config
+stdin:tty
+stdout:tty
+stderr:tty
+
+~/packages/other$ check-tty ⊘ cache disabled: no cache config
+stdin:not-tty
+stdout:not-tty
+stderr:not-tty
+
+$ check-tty ⊘ cache disabled: no cache config
+stdin:not-tty
+stdout:not-tty
+stderr:not-tty
+
+
+━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+    Vite+ Task Runner • Execution Summary
+━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+Statistics:   4 tasks • 0 cache hits • 0 cache misses • 4 cache disabled
+Performance:  0% cache hit rate
+
+Task Details:
+────────────────────────────────────────────────
+  [1] stdio-graph-criteria-test#foo: $ check-tty ✓
+      → Cache disabled in task configuration
+  ·······················································
+  [2] stdio-graph-criteria-test#bar: $ check-tty ✓
+      → Cache disabled in task configuration
+  ·······················································
+  [3] other#check-tty: ~/packages/other$ check-tty ✓
+      → Cache disabled in task configuration
+  ·······················································
+  [4] stdio-graph-criteria-test#check-tty: $ check-tty ✓
+      → Cache disabled in task configuration
+━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

crates/vite_task_bin/tests/e2e_snapshots/fixtures/stdio-graph-criteria/snapshots/single-node chains inherit even with multi-node sibling graph.snap

@@ -0,0 +1,21 @@
+{
+  "cacheScripts": true,
+  "tasks": {
+    "check-tty": {
+      "command": "check-tty",
+      "cache": false
+    },
+    "bar": {
+      "command": "check-tty",
+      "cache": false
+    },
+    "foo": {
+      "command": "check-tty && vp run bar && vp run -r check-tty",
+      "cache": false
+    },
+    "foo-nested": {
+      "command": "vp run bar",
+      "cache": false
+    }
+  }
+}