fix: exclude cache directory from fspy tracking to prevent spurious cache misses

Tools like oxlint traverse node_modules/ during execution, which causes fspy
to record reads of files in the cache directory (SQLite DB, last-summary.json).
When these cache files change between runs, fspy reports them as changed inputs,
causing spurious cache misses.

Thread cache_dir_relative through Session -> ExecutionContext -> spawn_with_tracking
to filter out cache directory accesses alongside the existing .git exclusion.

Also adds summary-output e2e test fixture with 10 test cases covering compact
summary, --verbose, and --last-details.

Author: branchseer

crates/vite_task/src/session/execute/mod.rs

@@ -5,7 +5,7 @@ use std::{process::Stdio, sync::Arc};
 
 use futures_util::FutureExt;
 use tokio::io::AsyncWriteExt as _;
-use vite_path::AbsolutePath;
+use vite_path::{AbsolutePath, RelativePath};
 use vite_task_plan::{
     ExecutionGraph, ExecutionItemDisplay, ExecutionItemKind, LeafExecutionKind, SpawnCommand,
     SpawnExecution,
@@ -56,6 +56,11 @@ struct ExecutionContext<'a> {
     /// Base path for resolving relative paths in cache entries.
     /// Typically the workspace root.
     cache_base_path: &'a Arc<AbsolutePath>,
+    /// Cache directory path relative to the workspace root.
+    /// Used to exclude cache directory accesses from fspy tracking (the cache
+    /// directory is infrastructure, not a task input).
+    /// `None` when the cache directory is outside the workspace (custom `VITE_CACHE_PATH`).
+    cache_dir_relative: Option<&'a RelativePath>,
 }
 
 impl ExecutionContext<'_> {
@@ -152,9 +157,14 @@ impl ExecutionContext<'_> {
                     clippy::large_futures,
                     reason = "spawn execution with cache management creates large futures"
                 )]
-                let _ =
-                    execute_spawn(leaf_reporter, spawn_execution, self.cache, self.cache_base_path)
-                        .await;
+                let _ = execute_spawn(
+                    leaf_reporter,
+                    spawn_execution,
+                    self.cache,
+                    self.cache_base_path,
+                    self.cache_dir_relative,
+                )
+                .await;
             }
         }
     }
@@ -184,6 +194,7 @@ pub async fn execute_spawn(
     spawn_execution: &SpawnExecution,
     cache: &ExecutionCache,
     cache_base_path: &Arc<AbsolutePath>,
+    cache_dir_relative: Option<&RelativePath>,
 ) -> SpawnOutcome {
     let cache_metadata = spawn_execution.cache_metadata.as_ref();
 
@@ -293,6 +304,7 @@ pub async fn execute_spawn(
         &mut stdio_config.stdout_writer,
         &mut stdio_config.stderr_writer,
         track_result_with_cache_metadata.as_mut().map(|(track_result, _)| track_result),
+        cache_dir_relative,
     )
     .await
     {
@@ -418,6 +430,7 @@ impl Session<'_> {
             reporter: &mut *reporter,
             cache,
             cache_base_path: &self.workspace_path,
+            cache_dir_relative: self.cache_dir_relative.as_deref(),
         };
 
         // Execute the graph. Leaf-level errors are reported through the reporter

crates/vite_task/src/session/execute/spawn.rs

@@ -11,7 +11,7 @@ use fspy::AccessMode;
 use rustc_hash::FxHashSet;
 use serde::Serialize;
 use tokio::io::{AsyncReadExt as _, AsyncWrite, AsyncWriteExt as _};
-use vite_path::{AbsolutePath, RelativePathBuf};
+use vite_path::{AbsolutePath, RelativePath, RelativePathBuf};
 use vite_task_plan::SpawnCommand;
 
 use crate::collections::HashMap;
@@ -75,6 +75,7 @@ pub async fn spawn_with_tracking(
     stdout_writer: &mut (dyn AsyncWrite + Unpin),
     stderr_writer: &mut (dyn AsyncWrite + Unpin),
     track_result: Option<&mut SpawnTrackResult>,
+    cache_dir_relative: Option<&RelativePath>,
 ) -> anyhow::Result<SpawnResult> {
     /// The tracking state of the spawned process
     enum TrackingState<'a> {
@@ -206,6 +207,16 @@ pub async fn spawn_with_tracking(
             continue;
         }
 
+        // Skip cache directory accesses — the cache directory is infrastructure
+        // (SQLite DB, last-summary.json), not a task input. Tools like oxlint may
+        // traverse node_modules/ and read files in the cache directory, which would
+        // otherwise cause spurious cache misses when those files change between runs.
+        if let Some(cache_dir) = cache_dir_relative
+            && relative_path.as_path().strip_prefix(cache_dir).is_ok()
+        {
+            continue;
+        }
+
         if access.mode.contains(AccessMode::READ) {
             path_reads.entry(relative_path.clone()).or_insert(PathRead { read_dir_entries: false });
         }

crates/vite_task/src/session/mod.rs

@@ -15,7 +15,7 @@ use reporter::{
     summary::{LastRunSummary, ReadSummaryError, format_full_summary},
 };
 use rustc_hash::FxHashMap;
-use vite_path::{AbsolutePath, AbsolutePathBuf};
+use vite_path::{AbsolutePath, AbsolutePathBuf, RelativePathBuf};
 use vite_select::SelectItem;
 use vite_str::Str;
 use vite_task_graph::{
@@ -141,6 +141,11 @@ pub struct Session<'a> {
     /// processes (e.g., parallel `vp lib` commands) start simultaneously.
     cache: OnceCell<ExecutionCache>,
     cache_path: AbsolutePathBuf,
+    /// Cache directory path relative to the workspace root.
+    /// Used to exclude cache directory accesses from fspy tracking (the cache
+    /// directory is infrastructure, not a task input).
+    /// `None` when the cache directory is outside the workspace (custom `VITE_CACHE_PATH`).
+    cache_dir_relative: Option<RelativePathBuf>,
 }
 
 fn get_cache_path_of_workspace(workspace_root: &AbsolutePath) -> AbsolutePathBuf {
@@ -198,6 +203,12 @@ impl<'a> Session<'a> {
         let (workspace_root, _) = find_workspace_root(&cwd)?;
         let cache_path = get_cache_path_of_workspace(&workspace_root.path);
 
+        // Compute the cache directory path relative to the workspace root.
+        // Used to exclude cache directory accesses from fspy tracking.
+        // `None` if the cache path is outside the workspace (custom VITE_CACHE_PATH)
+        // or if stripping the prefix fails.
+        let cache_dir_relative = cache_path.strip_prefix(&workspace_root.path).ok().flatten();
+
         // Prepend workspace's node_modules/.bin to PATH
         let workspace_node_modules_bin = workspace_root.path.join("node_modules").join(".bin");
         prepend_path_env(&mut envs, &workspace_node_modules_bin)?;
@@ -214,6 +225,7 @@ impl<'a> Session<'a> {
             plan_request_parser: PlanRequestParser { command_handler: callbacks.command_handler },
             cache: OnceCell::new(),
             cache_path,
+            cache_dir_relative,
         })
     }
 
@@ -545,6 +557,7 @@ impl<'a> Session<'a> {
             &spawn_execution,
             cache,
             &self.workspace_path,
+            self.cache_dir_relative.as_deref(),
         )
         .await
         {

crates/vite_task_bin/tests/e2e_snapshots/fixtures/summary-output/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "summary-output-test",
+  "private": true
+}

crates/vite_task_bin/tests/e2e_snapshots/fixtures/summary-output/packages/a/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "@summary/a",
+  "scripts": {
+    "build": "print built-a"
+  }
+}

crates/vite_task_bin/tests/e2e_snapshots/fixtures/summary-output/packages/b/package.json

@@ -0,0 +1,9 @@
+{
+  "name": "@summary/b",
+  "dependencies": {
+    "@summary/a": "workspace:*"
+  },
+  "scripts": {
+    "build": "print built-b"
+  }
+}

crates/vite_task_bin/tests/e2e_snapshots/fixtures/summary-output/pnpm-workspace.yaml

@@ -0,0 +1,2 @@
+packages:
+  - packages/*

crates/vite_task_bin/tests/e2e_snapshots/fixtures/summary-output/snapshots.toml

@@ -0,0 +1,80 @@
+# Tests for compact and verbose summary output
+
+# Single task, cache miss → no summary at all
+[[e2e]]
+name = "single task cache miss shows no summary"
+cwd = "packages/a"
+steps = [
+  "vp run build",
+]
+
+# Single task, cache hit → compact one-liner
+[[e2e]]
+name = "single task cache hit shows compact summary"
+cwd = "packages/a"
+steps = [
+  "vp run build # first run, cache miss",
+  "vp run build # second run, cache hit → compact summary",
+]
+
+# Multi-task (recursive), all cache miss → compact summary with 0 hits
+[[e2e]]
+name = "multi task all cache miss shows compact summary"
+steps = [
+  "vp run -r build",
+]
+
+# Multi-task (recursive), some cache hits → compact summary with hit count
+[[e2e]]
+name = "multi task with cache hits shows compact summary"
+steps = [
+  "vp run -r build # first run, all miss",
+  "vp run -r build # second run, all hit",
+]
+
+# Single task with --verbose → full detailed summary
+[[e2e]]
+name = "single task verbose shows full summary"
+cwd = "packages/a"
+steps = [
+  "vp run -v build",
+]
+
+# Multi-task with --verbose → full detailed summary
+[[e2e]]
+name = "multi task verbose shows full summary"
+steps = [
+  "vp run -r -v build",
+]
+
+# Multi-task with --verbose after cache hits
+[[e2e]]
+name = "multi task verbose with cache hits shows full summary"
+steps = [
+  "vp run -r build # first run, populate cache",
+  "vp run -r -v build # second run, verbose with cache hits",
+]
+
+# --last-details with no previous run
+[[e2e]]
+name = "last details with no previous run shows error"
+steps = [
+  "vp run --last-details",
+]
+
+# --last-details after a run shows saved summary
+[[e2e]]
+name = "last details after run shows saved summary"
+cwd = "packages/a"
+steps = [
+  "vp run build # populate summary file",
+  "vp run --last-details # display saved summary",
+]
+
+# --last-details after a multi-task run
+[[e2e]]
+name = "last details after multi task run shows saved summary"
+steps = [
+  "vp run -r build # populate summary file",
+  "vp run --last-details # display saved summary",
+]

crates/vite_task_bin/tests/e2e_snapshots/fixtures/summary-output/snapshots/last details after multi task run shows saved summary.snap

@@ -0,0 +1,30 @@
+---
+source: crates/vite_task_bin/tests/e2e_snapshots/main.rs
+expression: e2e_outputs
+---
+> vp run -r build # populate summary file
+~/packages/a$ print built-a
+built-a
+
+~/packages/b$ print built-b
+built-b
+
+---
+[vp run] 0/2 cache hit (0%). (Run `vp run --verbose` for full details)
+> vp run --last-details # display saved summary
+
+━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+    Vite+ Task Runner • Execution Summary
+━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+Statistics:   2 tasks • 0 cache hits • 2 cache misses
+Performance:  0% cache hit rate
+
+Task Details:
+────────────────────────────────────────────────
+  [1] @summary/a#build: ~/packages/a$ print built-a ✓
+      → Cache miss: no previous cache entry found
+  ·······················································
+  [2] @summary/b#build: ~/packages/b$ print built-b ✓
+      → Cache miss: no previous cache entry found
+━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

crates/vite_task_bin/tests/e2e_snapshots/fixtures/summary-output/snapshots/last details after run shows saved summary.snap

@@ -0,0 +1,21 @@
+---
+source: crates/vite_task_bin/tests/e2e_snapshots/main.rs
+expression: e2e_outputs
+---
+> vp run build # populate summary file
+~/packages/a$ print built-a
+built-a
+> vp run --last-details # display saved summary
+
+━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+    Vite+ Task Runner • Execution Summary
+━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+Statistics:   1 tasks • 0 cache hits • 1 cache misses
+Performance:  0% cache hit rate
+
+Task Details:
+────────────────────────────────────────────────
+  [1] @summary/a#build: ~/packages/a$ print built-a ✓
+      → Cache miss: no previous cache entry found
+━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━