fix: exit with non-zero status for signal-terminated processes#118
Merged
branchseer merged 1 commit intomainfrom Jan 19, 2026
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
fengmk2
approved these changes
Jan 19, 2026
Member
Author
Merge activity
|
800039b to
b8b3df9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Improve exit status handling for processes terminated by signals on Unix systems.
What changed?
exit_status_to_code()function to properly handle processes terminated by signals on Unix systems, following the convention of returning 128 + signal numberExecutionEventKind::Finishto useExitStatusinstead ofi32to preserve signal informationNonefor status when no process was spawned (cache hit or in-process execution)How to test?
Run the new e2e test on a Unix system:
This should show a process terminated with exit code 134 (128 + 6 for SIGABRT).
Why make this change?
Previously, when a process was terminated by a signal on Unix systems, the exit code information was lost. This change ensures that signal terminations are properly reported with the standard convention of 128 + signal number, providing more accurate information about process failures.