Skip to content

fix: make packages optional in pnpm-workspace.yaml #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
branchseer merged 2 commits into from
Jan 23, 2026
Merged

fix: make packages optional in pnpm-workspace.yaml #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f815b2
fix: make `packages` optional in `pnpm-workspace.yaml`
branchseer Jan 23, 2026
084328e
add plan test
branchseer Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...ite_task_plan/tests/plan_snapshots/fixtures/pnpm-workspace-packages-optional/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "additional-envs",
"private": true,
"scripts": {
"hello": "echo hello"
}
}
1 change: 1 addition & 0 deletions ...k_plan/tests/plan_snapshots/fixtures/pnpm-workspace-packages-optional/pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# no `packages` field
3 changes: 3 additions & 0 deletions ...e_task_plan/tests/plan_snapshots/fixtures/pnpm-workspace-packages-optional/snapshots.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[[plan]]
name = "allow `packages` in pnpm-workspace.yaml to be optional"
args = ["run", "hello"]
53 changes: 53 additions & 0 deletions ...es-optional/snapshots/query - allow `packages` in pnpm-workspace.yaml to be optional.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
---
source: crates/vite_task_plan/tests/plan_snapshots/main.rs
expression: "&plan_json"
input_file: crates/vite_task_plan/tests/plan_snapshots/fixtures/pnpm-workspace-packages-optional
---
{
"root_node": {
"Expanded": [
{
"key": [
"<workspace>/",
"hello"
],
"node": {
"task_display": {
"package_name": "additional-envs",
"task_name": "hello",
"package_path": "<workspace>/"
},
"items": [
{
"execution_item_display": {
"task_display": {
"package_name": "additional-envs",
"task_name": "hello",
"package_path": "<workspace>/"
},
"command": "echo hello",
"and_item_index": null,
"cwd": "<workspace>/"
},
"kind": {
"Leaf": {
"InProcess": {
"kind": {
"Echo": {
"strings": [
"hello"
],
"trailing_newline": true
}
}
}
}
}
}
]
},
"neighbors": []
}
]
}
}
35 changes: 35 additions & 0 deletions .../tests/plan_snapshots/fixtures/pnpm-workspace-packages-optional/snapshots/task graph.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
---
source: crates/vite_task_plan/tests/plan_snapshots/main.rs
expression: task_graph_json
input_file: crates/vite_task_plan/tests/plan_snapshots/fixtures/pnpm-workspace-packages-optional
---
[
{
"key": [
"<workspace>/",
"hello"
],
"node": {
"task_display": {
"package_name": "additional-envs",
"task_name": "hello",
"package_path": "<workspace>/"
},
"resolved_config": {
"command": "echo hello",
"resolved_options": {
"cwd": "<workspace>/",
"cache_config": {
"env_config": {
"fingerprinted_envs": [],
"pass_through_envs": [
"<default pass-through envs>"
]
}
}
}
}
},
"neighbors": []
}
]
1 change: 1 addition & 0 deletions crates/vite_workspace/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ struct PnpmWorkspace {
/// The packages to include in the workspace.
///
/// <https://pnpm.io/pnpm-workspace_yaml>
#[serde(default)]
packages: Vec<Str>,
}

Expand Down