Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
branchseer
changed the title
branchseer
changed the title
fengmk2
approved these changes
Feb 10, 2026
Member
Author
Merge activity
|
branchseer
changed the base branch from
refactor_change_UserTaskOptions_to_UserCacheConfig_for_synthetic_tasks
to
graphite-base/147
Resolve all errors from `cargo clippy --workspace --all-targets --all-features -- --deny warnings` across every crate. Key changes: - Replace disallowed types (HashMap→FxHashMap, HashSet→FxHashSet, String→Str, PathBuf→AbsolutePath) per workspace .clippy.toml, using #[expect] with reasons where external APIs require std types - Replace std::format! with vite_str::format! and str::replace with cow_utils::cow_replace - Add #[expect] attributes (never #[allow]) for unavoidable lints like future_not_send, large_futures, large_enum_variant, too_many_lines, each with a reason - Add missing `# Errors` doc sections on public fallible functions - Fix option_if_let_else, significant_drop_tightening, similar_names, pass_by_value, match_same_arms, items_after_statements, and other pedantic lints - Add per-crate .clippy.toml for fspy_e2e and vite_path where derive macros need std types - Convert fspy test_utils.rs from file to module directory for proper #[expect] scoping Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix const fn with non-const Windows code path in native_str.rs - Add non-vite crate allows to fspy_detours_sys, fspy_preload_windows - Fix all clippy warnings in Windows-only code (SAFETY comments, expect attrs, format args, const fns, etc.) - Fix unfulfilled lint expectations with cfg_attr for platform-specific code - Move CI clippy check into test job, rename lint job to fmt Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Revert linux.rs macro exports to pub(crate) (macro_rules! macros cannot be pub, causing E0364 on Linux) - Use pub(crate) glob re-export with redundant_pub_crate expect - Move SAFETY comment to directly precede unsafe block in winapi_utils - Add clippy component to test job's setup-rust step Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Artifact dependencies (fspy_test_bin) target linux-musl, which requires a musl-capable linker. On non-Linux hosts, delegate to cargo-zigbuild's zig cc via wrapper scripts in .cargo/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Move wildcard_imports allow to crate-level in fspy_detours_sys to avoid unfulfilled expect on test target and bindgen test failure - Fix all clippy warnings in fspy_seccomp_unotify: add SAFETY comments, feature-gate bindings module, fix unreadable literals, add missing docs, and address pedantic/nursery lints Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add SAFETY comment and doc sections for fspy_shared_unix Linux code - Fix useless as_ref() in elf.rs, derivable_impls in shebang.rs - Suppress struct_field_names for seccomp_payload field - Restore original individual use statements in generated_bindings.rs to match bindgen test expectations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add generated_bindings.rs to rustfmt ignore list to prevent imports_granularity from consolidating bindgen-generated imports - Use cfg_attr to conditionally apply derivable_impls expect only on non-Apple targets where the lint fires Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fully restore generated_bindings.rs to match bindgen test output (previous cargo clippy --fix reformatted the prettyplease output) - Fix #[allow(unused)] in intercept_inner macro to satisfy allow_attributes and allow_attributes_without_reason lints Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add SAFETY comments to all unsafe blocks in macro-generated and interception code - Fix format string inlining, unnecessary semicolons, explicit deref - Convert match-for-equality to if, fix wildcard imports - Fix assert_eq!(x, true/false) to assert!(x)/assert!(!x) in elf tests - Fix redundant closure and needless borrow in fspy crate Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add `just lint-linux` and `just lint-windows` for cross-compiling clippy checks via cargo-zigbuild and cargo-xwin, and document them in CLAUDE.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
branchseer
force-pushed
the
02-09-chore_fix_clippy_issues
branch
from
420d3d7 to
9e4a26e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve all errors from
cargo clippy --workspace --all-targets --all-features -- --deny warningsacross every crate.