fix: synthetic tasks inherit parent task's cache config#150
Merged
branchseer merged 2 commits intomainfrom Feb 11, 2026
Merged
Conversation
Synthetic tasks (e.g., `vp lint` → `oxlint`) now respect the parent task's cache configuration instead of always enabling their own cache. Cache is enabled only when both parent and synthetic want it, and parent settings like `passThroughEnvs` are properly propagated. - Add `ParentCacheConfig` enum (None/Disabled/Inherited) to represent parent cache state passed to synthetic task planning - Add `resolve_synthetic_cache_config` to merge parent and synthetic cache configs with clear precedence rules - Change `EnvConfig.pass_through_envs` from `Arc<[Str]>` to `FxHashSet<Str>` for natural deduplication during merge - Sort pass-through envs for deterministic cache fingerprinting - Add `synthetic-cache-disabled` test fixture with 6 cases covering disabled scripts, disabled tasks, enabled tasks, env inheritance, and expanded query task independence Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fengmk2
approved these changes
Feb 11, 2026
branchseer
deleted the
02-10-fix_allow_to_disable_cache_for_synthetic_tasks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synthetic tasks (e.g.,
vp lint→oxlint) now respect the parent task's cache configurationSynthetic tasks (e.g.,
vp lint→oxlint) now respect the parenttask's cache configuration instead of always enabling their own cache.
Cache is enabled only when both parent and synthetic want it, and
parent settings like
passThroughEnvsare properly propagated.ParentCacheConfigenum (None/Disabled/Inherited) to representparent cache state passed to synthetic task planning
resolve_synthetic_cache_configto merge parent and syntheticcache configs with clear precedence rules
EnvConfig.pass_through_envsfromArc<[Str]>toFxHashSet<Str>for natural deduplication during mergesynthetic-cache-disabledtest fixture with 6 cases coveringdisabled scripts, disabled tasks, enabled tasks, env inheritance,
and expanded query task independence