refactor: remove ExecutionPlan wrapper struct#157
Merged
branchseer merged 2 commits intomainfrom Feb 15, 2026
Merged
Conversation
ExecutionPlan was a trivial single-field wrapper around ExecutionItemKind that added no value. Its methods either delegated trivially or were associated functions that didn't even return Self. - Promote plan_query() and plan_synthetic() to pub free functions - plan_synthetic() now returns SpawnExecution directly instead of wrapping/unwrapping through ExecutionPlan - Move Serialize impl to ExecutionGraph directly, removing the serialize_with indirection on ExecutionItemKind::Expanded - Remove unused methods: plan(), is_empty(), root_node(), into_root_node(), from_execution_graph()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExecutionPlanstruct which was a trivial single-field wrapper aroundExecutionItemKindthat added no valueplan_query()andplan_synthetic()to pub free functions invite_task_planplan_synthetic()now returnsSpawnExecutiondirectly instead of wrapping/unwrapping throughExecutionPlanSerializeimpl toExecutionGraphdirectly, removing theserialize_withindirection onExecutionItemKind::Expandedplan(),is_empty(),root_node(),into_root_node(),from_execution_graph()