refactor: replace error strings in reporter with ExecutionError enum#159
Merged
branchseer merged 1 commit intomainfrom Feb 15, 2026
Merged
refactor: replace error strings in reporter with ExecutionError enum#159branchseer merged 1 commit intomainfrom
branchseer merged 1 commit intomainfrom
Conversation
Replace the four hardcoded error format strings passed through
LeafExecutionReporter::finish() with a typed ExecutionError enum
using thiserror. The enum has three variants:
- Cache { kind, source } — covers both lookup and update failures
- Spawn — process spawn failure
- PostRunFingerprint — fingerprint creation failure
The reporter converts the error chain to a display string at the
boundary using anyhow's {:#} formatter, preserving the existing
output format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExecutionErrorenum (withthiserror) to replace the four hardcoded error format strings passed throughLeafExecutionReporter::finish()Cache { kind, source }variant with aCacheErrorKindsub-enum{:#}formatter, preserving existing output format