refactor: implement Index<LeafExecutionPath> for ExecutionGraph#162
Merged
branchseer merged 1 commit intomainfrom Feb 15, 2026
Merged
refactor: implement Index<LeafExecutionPath> for ExecutionGraph#162branchseer merged 1 commit intomainfrom
branchseer merged 1 commit intomainfrom
Conversation
Add Index<&LeafExecutionPath> for ExecutionGraph with Output = LeafExecutionKind, providing direct indexing into nested execution graphs to retrieve leaf execution kinds. - Extract shared graph traversal into LeafExecutionPath::resolve_item() - Remove Option from display fields in labeled reporter (was unreachable dead code) - Add explicit Index<NodeIndex<Ix>> on AcyclicGraph to prevent shadowing through Deref
branchseer
added a commit
that referenced
this pull request
Feb 15, 2026
Remove vestiges left by the previous refactor (#162): - summary_buf: was unconditionally Some(...) after the is_single_displayless condition was removed — unwrap the Option - is_cache_hit field on LabeledLeafReporter: set but never read after its only consumer was removed
branchseer
added a commit
that referenced
this pull request
Feb 15, 2026
…163) ## Summary Follow-up to #162 — remove vestiges left by that refactor: - **`summary_buf`**: was unconditionally `Some(...)` after the `is_single_displayless` condition was removed. Unwrap the `Option` and write the buffer directly. - **`is_cache_hit`** field on `LabeledLeafReporter`: set in `start()` but never read — its only consumer was the `self.display.is_none() && self.is_cache_hit` block removed in #162. Remove the field, its initialization, and its assignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Index<&LeafExecutionPath>forExecutionGraphwithOutput = LeafExecutionKind, enabling direct indexing into nested execution graphs to retrieve leaf execution kindsLeafExecutionPath::resolve_item(), used by both theIndeximpl and display resolution inlabeled.rsOptionwrapper fromdisplayfields inExecutionInfoandLabeledLeafReporter— theNonecase was unreachable dead code (paths are never empty at the call site)Index<NodeIndex<Ix>>onAcyclicGraphto prevent the newIndeximpl from shadowingNodeIndexindexing that was previously available throughDeref