refactor: remove dead Option and is_cache_hit from labeled reporter#163
Merged
branchseer merged 1 commit intomainfrom Feb 15, 2026
Merged
refactor: remove dead Option and is_cache_hit from labeled reporter#163branchseer merged 1 commit intomainfrom
branchseer merged 1 commit intomainfrom
Conversation
Remove vestiges left by the previous refactor (#162): - summary_buf: was unconditionally Some(...) after the is_single_displayless condition was removed — unwrap the Option - is_cache_hit field on LabeledLeafReporter: set but never read after its only consumer was removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #162 — remove vestiges left by that refactor:
summary_buf: was unconditionallySome(...)after theis_single_displaylesscondition was removed. Unwrap theOptionand write the buffer directly.is_cache_hitfield onLabeledLeafReporter: set instart()but never read — its only consumer was theself.display.is_none() && self.is_cache_hitblock removed in refactor: implement Index<LeafExecutionPath> for ExecutionGraph #162. Remove the field, its initialization, and its assignment.