fix: use leaf graph path for stdio suggestion#167
Merged
Brooooooklyn merged 2 commits intomainfrom Feb 23, 2026
Merged
Conversation
fengmk2
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

User-facing changes
vp run build1 && vp run build2) with cache disabled: stdin is interactive, and outputs are naturally grouped because there is no parallel execution.vp run -r build, and tasks with cache enabled: outputs are piped and collected, and interactive stdin is disabled. We will print outputs one by one after each task is finished.Technical changes
spawn_leaf_countstdio heuristic with per-leaf evaluation based on graph structure along eachLeafExecutionPath.LeafExecutionPath::all_containing_graphs_single_node(...)to determine whether a leaf is inside only single-node graphs (root + expanded ancestors).new_leaf_execution(...), storing the computed suggestion onLabeledLeafReporterand using it instart(...).count_spawn_leaves(...)logic and rewrote labeled reporter unit tests to validate graph-path criteria and ancestor behavior.stdio-graph-criteriathat exercises mixed&&+ expanded graph cases and verifies tty behavior via snapshots.Validation
cargo test -p vite_task labeled_reportercargo test -p vite_task_bin --test e2e_snapshots -- stdio-graph-criteriacargo test -p vite_task_bin --test e2e_snapshots -- stdin-inheritance