fix: clear FD_CLOEXEC on stdio fds in spawn_inherited#172
Merged
branchseer merged 2 commits intomainfrom Feb 25, 2026
Merged
Conversation
libuv (used by Node.js) marks stdin/stdout/stderr as close-on-exec, which causes them to be closed when the child process calls exec(). This resulted in the child's fds 0-2 being closed after exec, and Node.js reopening them as /dev/null, silently discarding all output. Add a pre_exec hook to spawn_inherited() that clears FD_CLOEXEC on fds 0, 1, 2 before exec, matching the existing fix in vite-plus's vite_command::fix_stdio_streams(). Ref: libuv/libuv#2062
Member
Author
|
everything come back now voidzero-dev/vite-plus@127038a |
branchseer
approved these changes
Feb 25, 2026
Member
|
@fengmk2 I removed the added test since it can't validate the fix without the node environment. Let's do the test in vite-plus. |
fengmk2
added a commit
to voidzero-dev/vite-plus
that referenced
this pull request
Feb 25, 2026
fengmk2
added a commit
to voidzero-dev/vite-plus
that referenced
this pull request
Feb 25, 2026
fengmk2
added a commit
to voidzero-dev/vite-plus
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libuv (used by Node.js) marks stdin/stdout/stderr as close-on-exec,
which causes them to be closed when the child process calls exec().
This resulted in the child's fds 0-2 being closed after exec, and
Node.js reopening them as /dev/null, silently discarding all output.
Add a pre_exec hook to spawn_inherited() that clears FD_CLOEXEC on
fds 0, 1, 2 before exec, matching the existing fix in vite-plus's
vite_command::fix_stdio_streams().
Ref: libuv/libuv#2062