feat: restrict interactive task selector to bare vp run and cwd-only#183
Merged
branchseer merged 8 commits intomainfrom Mar 2, 2026
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fengmk2
approved these changes
Mar 2, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…lvedRunCommand Defer TaskSpecifier parsing to into_query_plan_request where the structured fields are actually needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Derive Clone on ResolvedRunCommand and pass the whole struct instead of individual flags and additional_args fields. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… Option<ExitStatus> handle_no_task now mutates run_command.task_specifier in place on interactive selection and returns None, letting the caller plan and execute through the single LabeledReporterBuilder + execute_graph site. Non-interactive list mode returns Some(ExitStatus) directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Check task_specifier before calling plan_from_cli_run_resolved, removing the is_missing_task_specifier error path and unwrap_or_default. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
branchseer
deleted the
03-02-feat_restrict_interactive_task_selector_to_bare_vp_run_and_cwd-only
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vp runor simplevp run <taskname>(cwd-only). Running with scope flags like-r,-t,-w, or--filterwill show an error instead of the selector when the task is not found.Task "buid" not foundinstead of the genericno tasks matched the query.vp run --verbose(or any non-scope flag without a task) correctly errors with "No task specifier provided" instead of showing the selector.vp run buid --verbosestill enters the selector since--verboseis not a scope flag — only package-scope flags (-r,-t,-w,--filter) gate the selector.Test plan
cargo test -p vite_task_bin --test e2e_snapshots -- task-select— all passcargo test— all passjust lint— clean