Skip to content

chore: Styling changes to align with Vite+.#192

Merged
branchseer merged 2 commits intomainfrom
run-styling
Mar 4, 2026
Merged

chore: Styling changes to align with Vite+.#192
branchseer merged 2 commits intomainfrom
run-styling

Conversation

@cpojer
Copy link
Copy Markdown
Member

@cpojer cpojer commented Mar 4, 2026

This PR aligns the styling in Vite Task with Vite+. See https://discord.com/channels/1138376133969203262/1333702467485175870/1478694628461908069 for an upcoming Vite+ PR that adds this style for top-level commands.

Screenshot:
CleanShot 2026-03-04 at 19 05 53@2x

Comment thread .github/workflows/ci.yml Outdated
Comment on lines +114 to +115
# cargo-shear currently misflags the `fspy_test_bin` artifact bindep in crates/fspy.
- run: cargo shear --exclude fspy
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change here and down in justfile. Somehow cargo shear reports the fspy test lib as unused, then removes it, and it breaks the build. Somehow adding it to the ignores is not working, but this solution works. I'm not an expert, might be wrong, just trying to get CI to green 🙇‍♂️

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--exclude fspy somehow triggers an error in CI. I've reverted it.

cargo shear's report on fspy is a false positive warning. I think it's a bug of cargo-shear and will try to fix it on its side.

@branchseer branchseer merged commit b75475f into main Mar 4, 2026
6 checks passed
@branchseer branchseer deleted the run-styling branch March 4, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants