Skip to content

fix: Add extra newline between "Select a task" and the tasks to align with Vite+. #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpojer merged 1 commit into from
Mar 9, 2026
Merged

fix: Add extra newline between "Select a task" and the tasks to align with Vite+. #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/vite_select/src/interactive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@ pub fn render_items(writer: &mut impl Write, params: &RenderParams<'_>) -> anyho
"Select a task (\u{2191}/\u{2193}, Enter to run, Esc to clear): {q}{line_ending}",
)?;
}
lines += 1;
write!(writer, "{line_ending}")?;
lines += 2;
}

// Items
Expand Down Expand Up @@ -519,9 +520,11 @@ mod tests {
let output = render_interactive_to_string(&items, "", 80);
let mut lines = output.lines();
let prompt = lines.next().unwrap();
let spacer = lines.next().unwrap();
let selected = lines.next().unwrap();
let unselected = lines.next().unwrap();
assert_eq!(prompt, "Select a task (↑/↓, Enter to run, Esc to clear):");
assert!(spacer.is_empty());
assert_eq!(selected, " › build: echo build");
assert_eq!(unselected, " lint: echo lint");
}
Expand Down
2 changes: 1 addition & 1 deletion crates/vite_task_bin/tests/e2e_snapshots/fixtures/task-list/snapshots/vp run in script.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
---
source: crates/vite_task_bin/tests/e2e_snapshots/main.rs
assertion_line: 460
expression: e2e_outputs
---
> vp run list-tasks
@ expect-milestone: task-select::0
$ vp run ⊘ cache disabled
Select a task (↑/↓, Enter to run, Esc to clear):

› hello: echo hello from root
list-tasks: vp run
app#build: echo build app
Expand Down
5 changes: 5 additions & 0 deletions ...snapshots/fixtures/task-select-truncate/snapshots/interactive long command truncated.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,34 +7,39 @@ info:
> vp run
@ expect-milestone: task-select::0
Select a task (↑/↓, Enter to run, Esc to clear):

› build: echo build app
lint: echo lint app
long-cmd: echo aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa…
test: echo test app
@ write-key: down
@ expect-milestone: task-select::1
Select a task (↑/↓, Enter to run, Esc to clear):

build: echo build app
› lint: echo lint app
long-cmd: echo aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa…
test: echo test app
@ write-key: down
@ expect-milestone: task-select::2
Select a task (↑/↓, Enter to run, Esc to clear):

build: echo build app
lint: echo lint app
› long-cmd: echo aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa…
test: echo test app
@ write-key: down
@ expect-milestone: task-select::3
Select a task (↑/↓, Enter to run, Esc to clear):

build: echo build app
lint: echo lint app
long-cmd: echo aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa…
› test: echo test app
@ write-key: up
@ expect-milestone: task-select::2
Select a task (↑/↓, Enter to run, Esc to clear):

build: echo build app
lint: echo lint app
› long-cmd: echo aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa…
Expand Down
3 changes: 3 additions & 0 deletions ...pshots/fixtures/task-select/snapshots/interactive enter with no results does nothing.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ info:
> vp run
@ expect-milestone: task-select::0
Select a task (↑/↓, Enter to run, Esc to clear):

› build: echo build app
lint: echo lint app
test: echo test app
Expand All @@ -23,11 +24,13 @@ Select a task (↑/↓, Enter to run, Esc to clear):
@ write: zzzzz
@ expect-milestone: task-select:zzzzz:0
Select a task (↑/↓, Enter to run, Esc to clear): zzzzz

No matching tasks.
@ write-key: enter
@ write-key: escape
@ expect-milestone: task-select::0
Select a task (↑/↓, Enter to run, Esc to clear):

› build: echo build app
lint: echo lint app
test: echo test app
Expand Down
3 changes: 3 additions & 0 deletions ...n/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive escape clears query.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ info:
> vp run
@ expect-milestone: task-select::0
Select a task (↑/↓, Enter to run, Esc to clear):

› build: echo build app
lint: echo lint app
test: echo test app
Expand All @@ -23,11 +24,13 @@ Select a task (↑/↓, Enter to run, Esc to clear):
@ write: lin
@ expect-milestone: task-select:lin:0
Select a task (↑/↓, Enter to run, Esc to clear): lin

› lint: echo lint app
lib#lint: echo lint lib
@ write-key: escape
@ expect-milestone: task-select::0
Select a task (↑/↓, Enter to run, Esc to clear):

› build: echo build app
lint: echo lint app
test: echo test app
Expand Down
3 changes: 3 additions & 0 deletions ..._bin/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive scroll long list.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ info:
> vp run
@ expect-milestone: task-select::0
Select a task (↑/↓, Enter to run, Esc to clear):

› build: echo build app
lint: echo lint app
test: echo test app
Expand All @@ -30,6 +31,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
@ write-key: down
@ expect-milestone: task-select::8
Select a task (↑/↓, Enter to run, Esc to clear):

build: echo build app
lint: echo lint app
test: echo test app
Expand All @@ -53,6 +55,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
@ write-key: up
@ expect-milestone: task-select::0
Select a task (↑/↓, Enter to run, Esc to clear):

› build: echo build app
lint: echo lint app
test: echo test app
Expand Down
2 changes: 2 additions & 0 deletions ...s/e2e_snapshots/fixtures/task-select/snapshots/interactive search other package task.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ info:
> vp run
@ expect-milestone: task-select::0
Select a task (↑/↓, Enter to run, Esc to clear):

› build: echo build app
lint: echo lint app
test: echo test app
Expand All @@ -23,6 +24,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
@ write: typec
@ expect-milestone: task-select:typec:0
Select a task (↑/↓, Enter to run, Esc to clear): typec

› lib#typecheck: echo typecheck lib
@ write-key: enter
Selected task: lib#typecheck
Expand Down
2 changes: 2 additions & 0 deletions ...ts/fixtures/task-select/snapshots/interactive search preserves rating within package.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ info:
> vp run
@ expect-milestone: task-select::0
Select a task (↑/↓, Enter to run, Esc to clear):

› build: echo build lib
lint: echo lint lib
test: echo test lib
Expand All @@ -23,6 +24,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
@ write: t
@ expect-milestone: task-select:t:0
Select a task (↑/↓, Enter to run, Esc to clear): t

› test: echo test lib
typecheck: echo typecheck lib
lint: echo lint lib
Expand Down
2 changes: 2 additions & 0 deletions ...in/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive search then select.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ info:
> vp run
@ expect-milestone: task-select::0
Select a task (↑/↓, Enter to run, Esc to clear):

› build: echo build app
lint: echo lint app
test: echo test app
Expand All @@ -23,6 +24,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
@ write: lin
@ expect-milestone: task-select:lin:0
Select a task (↑/↓, Enter to run, Esc to clear): lin

› lint: echo lint app
lib#lint: echo lint lib
@ write-key: enter
Expand Down
2 changes: 2 additions & 0 deletions ..._snapshots/fixtures/task-select/snapshots/interactive search with hash skips reorder.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ info:
> vp run
@ expect-milestone: task-select::0
Select a task (↑/↓, Enter to run, Esc to clear):

› build: echo build app
lint: echo lint app
test: echo test app
Expand All @@ -23,6 +24,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
@ write: lib#
@ expect-milestone: task-select:lib#:0
Select a task (↑/↓, Enter to run, Esc to clear): lib#

› lib#build: echo build lib
lib#lint: echo lint lib
lib#test: echo test lib
Expand Down
1 change: 1 addition & 0 deletions .../tests/e2e_snapshots/fixtures/task-select/snapshots/interactive select task from lib.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ info:
> vp run
@ expect-milestone: task-select::0
Select a task (↑/↓, Enter to run, Esc to clear):

› build: echo build lib
lint: echo lint lib
test: echo test lib
Expand Down
2 changes: 2 additions & 0 deletions ..._task_bin/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive select task.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ info:
> vp run
@ expect-milestone: task-select::0
Select a task (↑/↓, Enter to run, Esc to clear):

› build: echo build app
lint: echo lint app
test: echo test app
Expand All @@ -23,6 +24,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
@ write-key: down
@ expect-milestone: task-select::1
Select a task (↑/↓, Enter to run, Esc to clear):

build: echo build app
› lint: echo lint app
test: echo test app
Expand Down
1 change: 1 addition & 0 deletions ..._bin/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive select with typo.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ info:
@ expect-milestone: task-select:buid:0
Task "buid" not found.
Select a task (↑/↓, Enter to run, Esc to clear): buid

› build: echo build app
lib#build: echo build lib
@ write-key: enter
Expand Down
1 change: 1 addition & 0 deletions ...tests/e2e_snapshots/fixtures/task-select/snapshots/verbose with typo enters selector.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ info:
@ expect-milestone: task-select:buid:0
Task "buid" not found.
Select a task (↑/↓, Enter to run, Esc to clear): buid

› build: echo build app
lib#build: echo build lib
@ write-key: enter
Expand Down