Skip to content

fix: align package headers with top-level items in task selector #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
branchseer merged 1 commit into from
Mar 11, 2026
Merged

fix: align package headers with top-level items in task selector #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/vite_select/src/interactive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ pub fn render_items(writer: &mut impl Write, params: &RenderParams<'_>) -> anyho
if is_interactive {
write!(
writer,
" {dim}{name}{reset}{line_ending}",
" {dim}{name}{reset}{line_ending}",
dim = SetAttribute(Attribute::Dim),
name = group_name,
reset = SetAttribute(Attribute::Reset),
Expand Down Expand Up @@ -797,7 +797,7 @@ mod tests {
assert_eq!(item_lines[0], " \u{203a} build: echo build app");
assert_eq!(item_lines[1], " lint: echo lint app");
// Group header
assert_eq!(item_lines[2], " lib (packages/lib)");
assert_eq!(item_lines[2], " lib (packages/lib)");
// Grouped items (indented by 2 more, less padding)
assert_eq!(item_lines[3], " build: echo build lib");
assert_eq!(item_lines[4], " lint: echo lint lib");
Expand All @@ -816,7 +816,7 @@ mod tests {
// All commands start at column 17 regardless of indent level
assert_eq!(item_lines[0], " \u{203a} build: echo build");
assert_eq!(item_lines[1], " typecheck: echo tc");
assert_eq!(item_lines[2], " lib");
assert_eq!(item_lines[2], " lib");
assert_eq!(item_lines[3], " build: echo build lib");
}

Expand Down
4 changes: 2 additions & 2 deletions crates/vite_task_bin/tests/e2e_snapshots/fixtures/task-list/snapshots/vp run in script.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ Select a task (↑/↓, Enter to run, Esc to clear):

› hello: echo hello from root
list-tasks: vp run
app (packages/app)
app (packages/app)
build: echo build app
lint: echo lint app
test: echo test app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
@ write-key: enter
$ vp run ⊘ cache disabled
Expand Down
8 changes: 4 additions & 4 deletions ...pshots/fixtures/task-select/snapshots/interactive enter with no results does nothing.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ Select a task (↑/↓, Enter to run, Esc to clear):
› build: echo build app
lint: echo lint app
test: echo test app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand All @@ -34,12 +34,12 @@ Select a task (↑/↓, Enter to run, Esc to clear):
› build: echo build app
lint: echo lint app
test: echo test app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand Down
10 changes: 5 additions & 5 deletions ...n/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive escape clears query.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ Select a task (↑/↓, Enter to run, Esc to clear):
› build: echo build app
lint: echo lint app
test: echo test app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand All @@ -26,7 +26,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
Select a task (↑/↓, Enter to run, Esc to clear): lin

› lint: echo lint app
lib (packages/lib)
lib (packages/lib)
lint: echo lint lib
@ write-key: escape
@ expect-milestone: task-select::0
Expand All @@ -35,12 +35,12 @@ Select a task (↑/↓, Enter to run, Esc to clear):
› build: echo build app
lint: echo lint app
test: echo test app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand Down
12 changes: 6 additions & 6 deletions ..._bin/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive scroll long list.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ Select a task (↑/↓, Enter to run, Esc to clear):
› build: echo build app
lint: echo lint app
test: echo test app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand All @@ -35,12 +35,12 @@ Select a task (↑/↓, Enter to run, Esc to clear):
build: echo build app
lint: echo lint app
test: echo test app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
› clean: echo clean root
deploy: echo deploy root
Expand All @@ -59,12 +59,12 @@ Select a task (↑/↓, Enter to run, Esc to clear):
› build: echo build app
lint: echo lint app
test: echo test app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand Down
6 changes: 3 additions & 3 deletions ...s/e2e_snapshots/fixtures/task-select/snapshots/interactive search other package task.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ Select a task (↑/↓, Enter to run, Esc to clear):
› build: echo build app
lint: echo lint app
test: echo test app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand All @@ -25,7 +25,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
@ expect-milestone: task-select:typec:0
Select a task (↑/↓, Enter to run, Esc to clear): typec

lib (packages/lib)
lib (packages/lib)
› typecheck: echo typecheck lib
@ write-key: enter
Selected task: lib#typecheck
Expand Down
6 changes: 3 additions & 3 deletions ...ts/fixtures/task-select/snapshots/interactive search preserves rating within package.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ Select a task (↑/↓, Enter to run, Esc to clear):
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
app (packages/app)
app (packages/app)
build: echo build app
lint: echo lint app
test: echo test app
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand All @@ -28,7 +28,7 @@ Select a task (↑/↓, Enter to run, Esc to clear): t
› test: echo test lib
typecheck: echo typecheck lib
lint: echo lint lib
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand Down
6 changes: 3 additions & 3 deletions ...in/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive search then select.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ Select a task (↑/↓, Enter to run, Esc to clear):
› build: echo build app
lint: echo lint app
test: echo test app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand All @@ -26,7 +26,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
Select a task (↑/↓, Enter to run, Esc to clear): lin

› lint: echo lint app
lib (packages/lib)
lib (packages/lib)
lint: echo lint lib
@ write-key: enter
Selected task: lint
Expand Down
6 changes: 3 additions & 3 deletions ..._snapshots/fixtures/task-select/snapshots/interactive search with hash skips reorder.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ Select a task (↑/↓, Enter to run, Esc to clear):
› build: echo build app
lint: echo lint app
test: echo test app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand All @@ -25,7 +25,7 @@ Select a task (↑/↓, Enter to run, Esc to clear):
@ expect-milestone: task-select:lib#:0
Select a task (↑/↓, Enter to run, Esc to clear): lib#

lib (packages/lib)
lib (packages/lib)
› build: echo build lib
lint: echo lint lib
test: echo test lib
Expand Down
8 changes: 4 additions & 4 deletions ...s/e2e_snapshots/fixtures/task-select/snapshots/interactive select from other package.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ Select a task (↑/↓, Enter to run, Esc to clear):
› build: echo build app
lint: echo lint app
test: echo test app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand All @@ -30,12 +30,12 @@ Select a task (↑/↓, Enter to run, Esc to clear):
build: echo build app
lint: echo lint app
test: echo test app
lib (packages/lib)
lib (packages/lib)
› build: echo build lib
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand Down
4 changes: 2 additions & 2 deletions .../tests/e2e_snapshots/fixtures/task-select/snapshots/interactive select task from lib.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ Select a task (↑/↓, Enter to run, Esc to clear):
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
app (packages/app)
app (packages/app)
build: echo build app
lint: echo lint app
test: echo test app
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand Down
8 changes: 4 additions & 4 deletions ..._task_bin/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive select task.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ Select a task (↑/↓, Enter to run, Esc to clear):
› build: echo build app
lint: echo lint app
test: echo test app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand All @@ -28,12 +28,12 @@ Select a task (↑/↓, Enter to run, Esc to clear):
build: echo build app
› lint: echo lint app
test: echo test app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
lint: echo lint lib
test: echo test lib
typecheck: echo typecheck lib
task-select-test (workspace root)
task-select-test (workspace root)
check: echo check root
clean: echo clean root
deploy: echo deploy root
Expand Down
2 changes: 1 addition & 1 deletion ..._bin/tests/e2e_snapshots/fixtures/task-select/snapshots/interactive select with typo.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Task "buid" not found.
Select a task (↑/↓, Enter to run, Esc to clear): buid

› build: echo build app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
@ write-key: enter
Selected task: build
Expand Down
2 changes: 1 addition & 1 deletion ...tests/e2e_snapshots/fixtures/task-select/snapshots/verbose with typo enters selector.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Task "buid" not found.
Select a task (↑/↓, Enter to run, Esc to clear): buid

› build: echo build app
lib (packages/lib)
lib (packages/lib)
build: echo build lib
@ write-key: enter
Selected task: build
Expand Down
Loading