refactor(fspy): change AccessMode to bitflags#36
Merged
branchseer merged 2 commits intomainfrom Nov 19, 2025
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fengmk2
reviewed
Nov 19, 2025
crates/fspy_shared/src/ipc/mod.rs
Outdated
| bitflags! { | ||
| // Attributes can be applied to flags types | ||
| #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)] | ||
| pub struct Flags: u32 { |
Member
Author
There was a problem hiding this comment.
Yes, thanks for noticing. Let me remove it.
fengmk2
approved these changes
Nov 19, 2025
branchseer
changed the base branch from
11-18-fix_fspy_correctly_report_access_mode_from_node_fs_on_windows
to
graphite-base/36
branchseer
force-pushed
the
graphite-base/36
branch
from
0657990 to
8b137ab
Compare
branchseer
force-pushed
the
11-19-refactor_fspy_change_accessmode_to_bitflags
branch
from
dd2edf0 to
bc58496
Compare
branchseer
force-pushed
the
11-19-refactor_fspy_change_accessmode_to_bitflags
branch
from
bc58496 to
bd1e224
Compare
branchseer
force-pushed
the
11-19-refactor_fspy_change_accessmode_to_bitflags
branch
from
bd1e224 to
87b225f
Compare
Brooooooklyn
deleted the
11-19-refactor_fspy_change_accessmode_to_bitflags
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.