Merged
Conversation
Migrate tests from vite_task/execute.rs and add new tests for envs.rs: Migrated tests: - test_force_color_auto_detection - test_task_envs_stable_ordering (Unix) - test_unix_env_case_sensitive (Unix) - test_windows_env_case_insensitive (Windows) - test_windows_path_case_insensitive_* (Windows) - test_unix_path_case_sensitive (Unix) New tests for changed/new logic: - test_btreemap_stable_fingerprint (BTreeMap ordering) - test_pass_through_envs_names_stored - test_package_path_* (path deduplication logic) - test_all_envs_mutated_after_resolve - test_error_env_value_not_valid_unicode - test_prepend_paths_removes_duplicates - test_sensitive_env_hashing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Move path-related tests from envs.rs to path_env.rs to better organize the test suite following the code reorganization. Changes: - Move 5 path prepending tests to path_env.rs - Remove 3 obsolete package_path tests that tested removed functionality - Clean up unused imports in envs.rs - Prefix unused parameters with underscores 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…ve test calls Update test calls to match the actual function signature which only takes 2 parameters (all_envs and env_config). Remove unused workspace_root variables and the unused vite_path::AbsolutePath import. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
branchseer
force-pushed
the
12-07-feat_task_plan
branch
from
3af1f2a to
2c023b0
Compare
fengmk2
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add vite_task_plan crate for task execution planning
This PR adds a new
vite_task_plancrate that handles planning task executions from the task graph. It introduces several key components:ExecutionPlan: Represents how tasks should be executed, with support for both spawned processes and in-process executionsResolvedEnvs: Handles environment variable resolution with proper fingerprinting for cachingPlanContext: Manages the execution context including working directory, environment variables, and call stack{ // direct recursion "build": "vite run build", // indirect recursion "ready": "vite run lint && vite run format", "format": "vite run ready && vite fmt", }