fix: Fixed empty rule validation

Author: Vojtěch Václav Porteš

src/builder.test.tsx

@@ -314,4 +314,48 @@ describe('#components/Builder', () => {
     });
     expect(wrapper.text()).toContain('This value is required');
   });
+
+  it('Does not render field validation errors for placeholder rules without a selected field', async () => {
+    const wrapper = mount(
+      <Builder
+        fields={fields}
+        data={[
+          {
+            type: 'GROUP',
+            value: 'AND',
+            isNegated: false,
+            children: [{ field: '' }],
+          },
+        ]}
+        showValidation
+      />
+    );
+
+    await Promise.resolve();
+    wrapper.update();
+
+    expect(wrapper.text()).not.toContain('Field "" is not defined');
+  });
+
+  it('Does not render field validation errors for placeholder rules with missing field values', async () => {
+    const wrapper = mount(
+      <Builder
+        fields={fields}
+        data={[
+          {
+            type: 'GROUP',
+            value: 'AND',
+            isNegated: false,
+            children: [{} as never],
+          },
+        ]}
+        showValidation
+      />
+    );
+
+    await Promise.resolve();
+    wrapper.update();
+
+    expect(wrapper.text()).not.toContain('is not defined');
+  });
 });

src/rule/rule.tsx

@@ -91,7 +91,7 @@ export const Rule: FC<IRuleProps> = ({
     return null;
   }
 
-  if (fieldRef === '') {
+  if (typeof fieldRef !== 'string' || fieldRef.trim() === '') {
     return (
       <RuleContainer
         dragHandle={dragHandle}

src/utils/validate-builder-query.util.test.ts

@@ -94,6 +94,23 @@ describe('validateBuilderQuery', () => {
     expect(result.issues).toHaveLength(0);
   });
 
+  it('Returns no issue for placeholder rules without a selected field', async () => {
+    const result = await validateBuilderQuery(
+      [
+        {
+          type: 'GROUP',
+          value: 'AND',
+          isNegated: false,
+          children: [{ id: 'rule-empty', field: '' }],
+        },
+      ],
+      context
+    );
+
+    expect(result.isValid).toEqual(true);
+    expect(result.issuesByRuleId['rule-empty']).toBeUndefined();
+  });
+
   it('Returns a range issue when numeric range order is invalid', async () => {
     const result = await validateBuilderQuery(
       [

src/utils/validation/validate-builder-query.util.ts

@@ -29,6 +29,10 @@ export const validateBuilderQuery = (
   const pendingIssueGroups: Array<Promise<IBuilderValidationIssue[]>> = [];
 
   for (const rule of rules) {
+    if (typeof rule.field !== 'string' || rule.field.trim() === '') {
+      continue;
+    }
+
     const field = context.fields.find((fieldItem) => fieldItem.field === rule.field);
 
     if (!field) {