Skip to content

Commit 4e28b8b

Browse files
committed
refractor: comments
Signed-off-by: Abhinav Singh <abhinavsingh717073@gmail.com>
1 parent ca301d2 commit 4e28b8b

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

pkg/workloadmanager/sandbox_helper.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,15 +170,12 @@ func (s *Server) initializePicoD(ctx context.Context, podIP string, entry *sandb
170170
return nil
171171
}
172172

173-
// Assuming PicoD listens on port 8080. If entrypoints have a specific port, we could use that.
174-
// We'll use the first port defined in the entry points.
175173
var port uint32 = 8080
176174
if len(entry.Ports) > 0 {
177175
port = entry.Ports[0].Port
178176
}
179177
endpoint := fmt.Sprintf("http://%s:%d/init", podIP, port)
180178

181-
// Generate JWT signed by Bootstrap Key
182179
token, err := GenerateInitJWT(entry.SessionID, GetCachedPublicKey())
183180
if err != nil {
184181
return fmt.Errorf("failed to generate init JWT: %w", err)

pkg/workloadmanager/workload_builder.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ func buildSandboxByAgentRuntime(namespace string, name string, ifm *Informers) (
297297
Ports: agentRuntimeObj.Spec.Ports,
298298
SessionID: sessionID,
299299
IdleTimeout: idleTimeout,
300-
AuthMode: runtimev1alpha1.AuthModeNone, // AgentRuntime doesn't explicitly have AuthMode defined in the CRD, but we default to None. Wait, does it?
300+
AuthMode: runtimev1alpha1.AuthModeNone, // AgentRuntime doesn't explicitly have AuthMode defined in the CRD, but we default to None.
301301
}
302302
return sandbox, entry, nil
303303
}

0 commit comments

Comments
 (0)