fix: address bot review feedback on secondary index implementation

Signed-off-by: Abhinav Singh <abhinavsingh717073@gmail.com>

Author: Abhinav-kodes

pkg/store/store_redis.go

@@ -26,6 +26,7 @@ import (
 	"time"
 
 	redisv9 "github.com/redis/go-redis/v9"
+	"k8s.io/klog/v2"
 
 	"github.com/volcano-sh/agentcube/pkg/common/types"
 )
@@ -149,9 +150,19 @@ func (rs *redisStore) GetSandboxBySessionID(ctx context.Context, sessionID strin
 // Uses SCAN to prevent blocking the Redis instance on large datasets.
 func (rs *redisStore) ListSandboxesByKind(ctx context.Context, kind string) ([]*types.SandboxInfo, error) {
 	kindKey := rs.kindIndexKeyPrefix + kind
-	sessionIDs, err := rs.cli.SMembers(ctx, kindKey).Result()
-	if err != nil {
-		return nil, fmt.Errorf("ListSandboxesByKind smembers failed: %w", err)
+	var sessionIDs []string
+	seenKeys := make(map[string]bool)
+
+	iter := rs.cli.SScan(ctx, kindKey, 0, "", 100).Iterator()
+	for iter.Next(ctx) {
+		val := iter.Val()
+		if !seenKeys[val] {
+			seenKeys[val] = true
+			sessionIDs = append(sessionIDs, val)
+		}
+	}
+	if err := iter.Err(); err != nil {
+		return nil, fmt.Errorf("ListSandboxesByKind sscan failed: %w", err)
 	}
 
 	if len(sessionIDs) == 0 {
@@ -251,9 +262,16 @@ func (rs *redisStore) DeleteSandboxBySessionID(ctx context.Context, sessionID st
 
 	// Fetch sandbox to get its kind for secondary index cleanup
 	var kind string
-	if b, err := rs.cli.Get(ctx, sessionKey).Bytes(); err == nil {
+	b, err := rs.cli.Get(ctx, sessionKey).Bytes()
+	if err != nil {
+		if !errors.Is(err, redisv9.Nil) {
+			klog.Warningf("Failed to get sandbox %s for kind cleanup, secondary index may be orphaned: %v", sessionID, err)
+		}
+	} else {
 		var sb types.SandboxInfo
-		if json.Unmarshal(b, &sb) == nil {
+		if err := json.Unmarshal(b, &sb); err != nil {
+			klog.Warningf("Failed to unmarshal sandbox %s for kind cleanup, secondary index may be orphaned: %v", sessionID, err)
+		} else {
 			kind = sb.Kind
 		}
 	}

pkg/store/store_valkey.go

@@ -181,9 +181,30 @@ func (vs *valkeyStore) GetSandboxBySessionID(ctx context.Context, sessionID stri
 // Uses SCAN to prevent blocking the Valkey instance on large datasets.
 func (vs *valkeyStore) ListSandboxesByKind(ctx context.Context, kind string) ([]*types.SandboxInfo, error) {
 	kindKey := vs.kindIndexKeyPrefix + kind
-	sessionIDs, err := vs.cli.Do(ctx, vs.cli.B().Smembers().Key(kindKey).Build()).AsStrSlice()
-	if err != nil && !valkey.IsValkeyNil(err) {
-		return nil, fmt.Errorf("ListSandboxesByKind smembers failed: %w", err)
+	var sessionIDs []string
+	seenKeys := make(map[string]bool)
+	cursor := uint64(0)
+
+	for {
+		scanRes, err := vs.cli.Do(ctx, vs.cli.B().Sscan().Key(kindKey).Cursor(cursor).Count(100).Build()).AsScanEntry()
+		if err != nil {
+			if valkey.IsValkeyNil(err) {
+				break
+			}
+			return nil, fmt.Errorf("ListSandboxesByKind sscan failed: %w", err)
+		}
+
+		for _, key := range scanRes.Elements {
+			if !seenKeys[key] {
+				seenKeys[key] = true
+				sessionIDs = append(sessionIDs, key)
+			}
+		}
+
+		cursor = scanRes.Cursor
+		if cursor == 0 {
+			break // Scan complete
+		}
 	}
 
 	if len(sessionIDs) == 0 {
@@ -270,9 +291,16 @@ func (vs *valkeyStore) DeleteSandboxBySessionID(ctx context.Context, sessionID s
 
 	// Fetch sandbox to get its kind for secondary index cleanup
 	var kind string
-	if b, err := vs.cli.Do(ctx, vs.cli.B().Get().Key(sessionKey).Build()).AsBytes(); err == nil {
+	b, err := vs.cli.Do(ctx, vs.cli.B().Get().Key(sessionKey).Build()).AsBytes()
+	if err != nil {
+		if !valkey.IsValkeyNil(err) {
+			klog.Warningf("Failed to get sandbox %s for kind cleanup, secondary index may be orphaned: %v", sessionID, err)
+		}
+	} else {
 		var sb types.SandboxInfo
-		if json.Unmarshal(b, &sb) == nil {
+		if err := json.Unmarshal(b, &sb); err != nil {
+			klog.Warningf("Failed to unmarshal sandbox %s for kind cleanup, secondary index may be orphaned: %v", sessionID, err)
+		} else {
 			kind = sb.Kind
 		}
 	}