refactor(picod): use local variable for http.Server in Run

Signed-off-by: Abhinav Singh <abhinavsingh717073@gmail.com>

Author: Abhinav-kodes

pkg/picod/server.go

@@ -36,7 +36,6 @@ type Config struct {
 // Server defines the PicoD HTTP server
 type Server struct {
 	engine       *gin.Engine
-	httpServer   *http.Server
 	config       Config
 	authManager  *AuthManager
 	startTime    time.Time
@@ -102,7 +101,7 @@ func (s *Server) Run(ctx context.Context) error {
 	addr := fmt.Sprintf(":%d", s.config.Port)
 	klog.Infof("PicoD server starting on %s", addr)
 
-	s.httpServer = &http.Server{
+	server := &http.Server{
 		Addr:              addr,
 		Handler:           s.engine,
 		ReadHeaderTimeout: 10 * time.Second, // Prevent Slowloris attacks
@@ -114,13 +113,13 @@ func (s *Server) Run(ctx context.Context) error {
 		// Allow enough time for in-flight commands to finish (default timeout is 60s).
 		shutdownCtx, cancel := context.WithTimeout(context.Background(), 90*time.Second)
 		defer cancel()
-		if err := s.httpServer.Shutdown(shutdownCtx); err != nil {
+		if err := server.Shutdown(shutdownCtx); err != nil {
 			klog.Errorf("HTTP server shutdown error: %v", err)
 		}
 		close(idleConnsClosed)
 	}()
 
-	if err := s.httpServer.ListenAndServe(); err != http.ErrServerClosed {
+	if err := server.ListenAndServe(); err != http.ErrServerClosed {
 		return err
 	}