fix: normalize mixed datetime inputs#367
Open
sudo-yf wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #368.
Normalize mixed datetime inputs before comparisons so legacy local naive timestamps and newer ISO8601
Z/offset timestamps can coexist safely.This addresses screenshot ingestion, vault monitoring, screenshot processing, scheduled consumption timers, and related context operations where aware datetimes could otherwise be compared with naive local
datetime.now()values.What changed
opencontext.utils.datetime_utilsfor local-naive datetime normalization.Z/offset inputs at API/storage processing boundaries.Tests
python3 -m unittest tests/test_datetime_normalization.pypython3 -m py_compile opencontext/utils/datetime_utils.py opencontext/context_capture/vault_document_monitor.py opencontext/context_consumption/generation/smart_tip_generator.py opencontext/context_processing/processor/screenshot_processor.py opencontext/managers/consumption_manager.py opencontext/server/context_operations.py