Skip to content

Commit 13ec0cf

Browse files
scott-kim-7scott.kimclaude
authored
fix(bot): add missing sender_name param in Slack and Email channels (#3104)
Commit 4d34025 added the required `sender_name` parameter to `BaseChannel._handle_message()` and updated `feishu.py`, but `slack.py` and `email.py` were not updated in the same change. This caused a `TypeError` on every inbound message in both channels. Because Slack SDK swallows exceptions in asyncio listener callbacks, the error was silent — the bot received events, added emoji reactions, but never called the LLM or sent any reply. Fix: pass `sender_name=sender_id` in SlackChannel and `sender_name=sender` in EmailChannel. Co-authored-by: scott.kim <scott@ScottMacBookPro.local> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 49b8e3d commit 13ec0cf

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

bot/vikingbot/channels/email.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ async def start(self) -> None:
8989

9090
await self._handle_message(
9191
sender_id=sender,
92+
sender_name=sender,
9293
chat_id=sender,
9394
content=item["content"],
9495
metadata=item.get("metadata", {}),

bot/vikingbot/channels/slack.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ async def _on_socket_request(
167167

168168
await self._handle_message(
169169
sender_id=sender_id,
170+
sender_name=sender_id,
170171
chat_id=chat_id,
171172
content=text,
172173
metadata={

0 commit comments

Comments
 (0)