Skip to content

fix(docker): remove invalid ragfs python-source config #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhoujh01 wants to merge 1 commit into from
Closed

fix(docker): remove invalid ragfs python-source config #1533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion crates/ragfs-python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,3 @@ requires-python = ">=3.10"
[tool.maturin]
features = ["s3"]
abi3 = true
python-source = "3.10"
11 changes: 11 additions & 0 deletions tests/misc/test_root_docker_image_packaging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,17 @@ def test_ragfs_python_uses_pyo3_version_with_python_314_support():
assert 'pyo3 = { version = "0.27"' in cargo_toml


def test_ragfs_python_python_source_points_to_existing_package_dir():
pyproject = _read_text("crates/ragfs-python/pyproject.toml")

match = re.search(r'^python-source = "(?P<path>[^"]+)"$', pyproject, re.MULTILINE)
if match is None:
return

package_dir = REPO_ROOT / "crates/ragfs-python" / match.group("path")
assert package_dir.is_dir(), f"Configured python-source directory is missing: {package_dir}"


def test_root_build_system_includes_maturin_for_isolated_builds():
pyproject = _read_text("pyproject.toml")
setup_py = _read_text("setup.py")
Expand Down
Loading