fix(ragfs): load Windows abi3 pyd artifact#1801
Merged
ZaynJarvis merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
修复 Windows wheel 构建中 ragfs Python binding 提取失败的问题。PR #1756 将 loader 和打包逻辑收紧到 stable ABI artifact,方向正确,但 Windows 的 maturin abi3 wheel 内部扩展文件名通常是
ragfs_python.pyd,不是ragfs_python.abi3.pyd,导致构建成功后被误判为缺失。本 PR 保留“不加载 cpython-specific 旧产物”的原则,同时允许 Windows stable ABI exact artifact
ragfs_python.pyd被打包和加载。Related Issue
N/A
Type of Change
Changes Made
setup.py从 maturin wheel 中提取 Windows stable ABI artifactragfs_python.pyd。openviking.pyagfsloader,在 Windows 优先查找ragfs_python.pyd,并继续兼容ragfs_python.abi3.pyd。ragfs_python.pyd加载路径和打包提取规则。Testing
已执行:
.venv/bin/python -m pytest tests/misc/test_abi3_packaging_config.py tests/misc/test_pyagfs_loader.py -qgit diff --checkChecklist
Screenshots (if applicable)
N/A
Additional Notes
本地 pre-commit hook 绑定的系统 Python 缺少
pre_commit模块,因此提交使用了--no-verify;已手动运行相关 pytest 和git diff --check。targeted pytest 仍会输出仓库已有的 Pydantic/requests warnings,与本次改动无关。