feat(cli): publish native CLI to npm on tag push#1944
Open
ZaynJarvis wants to merge 1 commit intomainfrom
Open
feat(cli): publish native CLI to npm on tag push#1944ZaynJarvis wants to merge 1 commit intomainfrom
ZaynJarvis wants to merge 1 commit intomainfrom
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Replace GitHub Release with npm publishing for CLI tags (cli@*).
Each tag triggers: build 5 platform binaries → publish platform-specific
@openviking/cli-{os}-{arch} packages → publish @openviking/cli wrapper.
- Add npm/cli/ wrapper package with postinstall help message
- Generate platform packages in CI from build artifacts
- Remove GitHub Release and artifact upload from CLI workflow
Required GitHub secret: NPM_TOKEN
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
39c7802 to
bcd1fd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli@*)@openviking/cli-{os}-{arch}packages → publish@openviking/cliwrappernpm/cli/wrapper package with JS shim that loads platform-specific native binary + postinstall help messageRequired GitHub secret
NPM_TOKEN— npm automation token with publish access to the@openvikingorg. Must have 2FA bypass enabled (granular access token).How it works
cli@0.3.15@openviking/cli-{platform}with properos/cpufields@openviking/clipackage is published with version injected from the tag andoptionalDependenciespointing to the platform packagesInstall flow
npm i -g @openviking/cli # npm automatically picks the right platform binary via optionalDependencies ov --versionTest plan
NPM_TOKENin GitHub repo secretscli@0.3.15) and verify all 6 packages publishnpm i -g @openviking/cliinstalls correctly on macOS and Linux🤖 Generated with Claude Code