Skip to content

fix(openclaw): guide media attachments through ov_import#1946

Open
Mijamind719 wants to merge 1 commit intovolcengine:mainfrom
Mijamind719:codex/openclaw-media-ov-import
Open

fix(openclaw): guide media attachments through ov_import#1946
Mijamind719 wants to merge 1 commit intovolcengine:mainfrom
Mijamind719:codex/openclaw-media-ov-import

Conversation

@Mijamind719
Copy link
Copy Markdown
Collaborator

@Mijamind719 Mijamind719 commented May 9, 2026

Summary

Fixes #1945.

Fixes the local OpenClaw chat flow where an attached document like [media attached: /path/to/file.xlsx ...] may fail to save to OpenViking because the model invents an unsupported upload endpoint instead of calling ov_import.

This PR:

  • clarifies the ov_import tool description so OpenClaw media attachment paths are passed as the source
  • tells the model not to invent OpenViking upload REST endpoints
  • adds a unit test covering local media-style .xlsx import via temp_upload -> resources

Testing

cd examples/openclaw-plugin
npm test -- --run tests/ut/tools.test.ts tests/ut/client.test.ts

Result: 2 test files passed, 73 tests passed.

Real E2E, 2026-05-09:

  • started local OpenViking server on 127.0.0.1:19633
  • started local OpenClaw gateway profile ov-import-e2e on 127.0.0.1:19634
  • sent chat message with [media attached: /var/folders/.../大秦-TOP20.xlsx (...)]
  • OpenClaw tool report included ov_import; model called only ov_import
  • OV returned viking://resources/大秦-TOP20
  • verified by REST: viking://resources/大秦-TOP20/大秦-TOP20.md contains openclaw chat e2e unique 2026-05-09

Note: during local E2E I also found an OpenClaw core plugin-registry issue that can hide all plugin tools before ov_import is visible. This PR covers the OpenViking plugin-side guidance once the tool is exposed.

Clarify that OpenClaw media attachment paths should be passed to ov_import as local resource sources, and cover the temp_upload -> resources flow for local spreadsheet attachments.

Co-authored-by: GPT-5.5 <noreply@openai.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

1945 - Fully compliant

Compliant requirements:

  • Strengthened ov_import tool description
  • Added guidance to not invent upload endpoints
  • Added unit test for local media import
  • No changes to upload semantics or new APIs
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🏅 Score: 98
🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

OpenClaw chat media attachments are not reliably imported via ov_import

1 participant