refactor(cli): share RAM environment detection#1950
Open
duyua9 wants to merge 1 commit intovolcengine:mainfrom
Open
refactor(cli): share RAM environment detection#1950duyua9 wants to merge 1 commit intovolcengine:mainfrom
duyua9 wants to merge 1 commit intovolcengine:mainfrom
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the setup wizard's RAM detection into a reusable CLI environment helper. This keeps the existing
openviking-server initRAM-tier recommendations unchanged while making the detection logic available to future environment/doctor checks.Related Issue
Related to #1436
Type of Change
Changes Made
openviking_cli.utils.environment.get_system_ram_gb().setup_wizard.pyto reuse the shared helper for RAM-tier model recommendations.Testing
Commands run:
python3 -m pytest -o addopts='' --confcutdir=tests/cli tests/cli/test_environment.py tests/cli/test_setup_wizard.py::TestRAMRecommendations -q git diff --checkChecklist
Screenshots (if applicable)
N/A
Additional Notes
Full pytest collection was not run because this local environment is missing optional dependencies required by the repository-level test conftest. The scoped CLI tests above avoid that global conftest and cover the changed helper directly.